Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members 2020-03-16 #1718

Merged
merged 7 commits into from
Mar 17, 2020
Merged

Add members 2020-03-16 #1718

merged 7 commits into from
Mar 17, 2020

Conversation

mrbobbytables
Copy link
Member

@mrbobbytables mrbobbytables commented Mar 16, 2020 •
edited
Loading

fixes #1703
fixes #1707
fixes #1709
fixes #1711
fixes #1712
fixes #1713
fixes #1719

/area github-membership

@k8s-ci-robot k8s-ci-robot added area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 16, 2020
This was referenced Mar 16, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@mrbobbytables mrbobbytables mentioned this pull request Mar 17, 2020
Closed
6 tasks
nikhita
nikhita approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5f71b32 into kubernetes:master Mar 17, 2020
@mrbobbytables mrbobbytables deleted the add-members-2020-03-16 branch May 16, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@idealhack idealhack Awaiting requested review from idealhack

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@mrbobbytables @k8s-ci-robot @nikhita