-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update admins and approvers for -sigs/krew repos #1396
Conversation
@ahmetb: GitHub didn't allow me to request PR reviews from the following users: corneliusweig. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Per the original repo request, those folks were a part of the sig-cli-maintainers team: #599 (comment) |
🤦♂ I think I requested it as such back in the day assuming the sig-cli-maintainers is small enough. With this we still have SIG CLI leads in the list, so I think it's fine to go ahead. |
I don't have any objections myself, and defer to @soltysh and the sig-cli leads :) |
@soltysh PTAL again. |
- liggitt | ||
- mengqiy | ||
- monopole | ||
- pwittrock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What implications does it have when Phil is member of the admin group, but not in maintainers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly not sure, so adding back there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference: GitHub repo permissions comparison.
We setup maintainers to have write
permissions and admins to have admin
.
If a person is an admin, they already have all the permissions of someone with write
access.
It appears like during 732ea00 we have added a set of people do not directly work on krew and krew-index as admins/maintainers. This fixes that. Additionally, this moves juanvallejo out of admins/maintainers and promotes corneliusweig as such, since Juan hasn't been active in this repo. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It appears like during 732ea00 we have added a set of people do not
directly work on krew and krew-index as admins/maintainers. This fixes that.
Additionally, this moves juanvallejo out of admins/maintainers and promotes
corneliusweig as such, since Juan hasn't been active in this repo.
/assign @soltysh
/cc @corneliusweig