Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admins and approvers for -sigs/krew repos #1396

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Nov 6, 2019

It appears like during 732ea00 we have added a set of people do not
directly work on krew and krew-index as admins/maintainers. This fixes that.

Additionally, this moves juanvallejo out of admins/maintainers and promotes
corneliusweig as such, since Juan hasn't been active in this repo.

/assign @soltysh
/cc @corneliusweig

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

@ahmetb: GitHub didn't allow me to request PR reviews from the following users: corneliusweig.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

It appears like during 732ea00 we have added a set of people do not
directly work on krew and krew-index as admins/maintainers. This fixes that.

Additionally, this moves juanvallejo out of admins/maintainers and promotes
corneliusweig as such, since Juan hasn't been active in this repo.

/assign @soltysh
/cc @corneliusweig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Nov 6, 2019
@cblecker
Copy link
Member

cblecker commented Nov 6, 2019

Per the original repo request, those folks were a part of the sig-cli-maintainers team: #599 (comment)

@corneliusweig
Copy link
Contributor

Thanks for investigating this @cblecker. You probably know best if it's common practice to have all SIG-cli-maintainers in that list. Apart from @soltysh nobody of those has been active on krew or - to my knowledge - expressed interest in contributing.

@ahmetb
Copy link
Member Author

ahmetb commented Nov 7, 2019

Per the original repo request, those folks were a part of the sig-cli-maintainers team: #599 (comment)

🤦‍♂ I think I requested it as such back in the day assuming the sig-cli-maintainers is small enough. With this we still have SIG CLI leads in the list, so I think it's fine to go ahead.

@cblecker
Copy link
Member

cblecker commented Nov 8, 2019

I don't have any objections myself, and defer to @soltysh and the sig-cli leads :)

@ahmetb
Copy link
Member Author

ahmetb commented Nov 25, 2019

@soltysh PTAL again.

- liggitt
- mengqiy
- monopole
- pwittrock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What implications does it have when Phil is member of the admin group, but not in maintainers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly not sure, so adding back there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference: GitHub repo permissions comparison.
We setup maintainers to have write permissions and admins to have admin.
If a person is an admin, they already have all the permissions of someone with write access.

It appears like during 732ea00 we have added a set of people do not
directly work on krew and krew-index as admins/maintainers. This fixes that.

Additionally, this moves juanvallejo out of admins/maintainers and promotes
corneliusweig as such, since Juan hasn't been active in this repo.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0f89815 into kubernetes:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants