Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add teams for ingress-controller-conformance #1369

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Add teams for ingress-controller-conformance #1369

merged 1 commit into from
Oct 31, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Oct 31, 2019 •
edited
Loading

Ref: #1328

Repo has been migrated: https://github.com/kubernetes-sigs/ingress-controller-conformance

rhs and alexgervais are not kubernetes/kubernetes-sigs members yet.

/assign @mrbobbytables

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Oct 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@nikhita nikhita mentioned this pull request Oct 31, 2019
Closed
@mrbobbytables
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0dc0162 into kubernetes:master Oct 31, 2019
@nikhita nikhita deleted the ingress-controller-conformance branch November 4, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@thockin thockin Awaiting requested review from thockin

Assignees

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhita @k8s-ci-robot @mrbobbytables