Skip to content

Conversation

@cblecker
Copy link
Member

@cblecker cblecker commented Oct 2, 2018

fixes #120.
fixes #126.
fixes #127.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2018
@k8s-ci-robot k8s-ci-robot requested review from fejta and spiffxp October 2, 2018 18:07
@cblecker
Copy link
Member Author

cblecker commented Oct 2, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2018
@fejta
Copy link
Contributor

fejta commented Oct 2, 2018

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 2, 2018
@cblecker
Copy link
Member Author

cblecker commented Oct 2, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit b42a88d into kubernetes:master Oct 2, 2018
@cblecker cblecker deleted the memberships-oct2 branch October 2, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REQUEST: New kubernetes-sigs membership for xmudrii REQUEST: New membership for d-nishi REQUEST: New membership for leakingtapan

3 participants