Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @raelga to kubernetes-sigs/org #1250

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Add @raelga to kubernetes-sigs/org #1250

merged 1 commit into from
Oct 3, 2019

Conversation

raelga
Copy link
Member

@raelga raelga commented Oct 2, 2019

Adds sig-usability-reviewer team, initially populated with the admin/maintainer members and @raelga as a reviewer.

Closes #1243

/cc @tashimi

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/usability Categorizes an issue or PR as relevant to SIG Usability. labels Oct 2, 2019
@raelga raelga changed the title SIG Usability reviewers Add SIG Usability reviewers Oct 2, 2019
@cblecker
Copy link
Member

cblecker commented Oct 2, 2019

We don't typically have a "reviewer" GH team anymore as all org members have read access. What's the specific purpose of this?

@justaugustus
Copy link
Member

If it's meant as a global ping group, would suggest just sig-usability.

@tashimi
Copy link

tashimi commented Oct 2, 2019

What Rael wants is to be a member of kubernetes-sigs so he can be assigned issues on the project tracker for SIG-Usability. He's already a member of kubernetes org, but not kubernetes-sigs. What does he need to do to achieve this goal?

@justaugustus
Copy link
Member

@tashimi -- Gotcha! Thanks for the context.
@raelga -- All you need to do is add yourself to the members section of config/kubernetes-sigs/org.yaml (which you've already done). You'll get an invite from our robots not too long after this merges.

Can you drop the changes in config/kubernetes-sigs/sig-usability/teams.yaml?

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2019
@raelga raelga changed the title Add SIG Usability reviewers Add @raelga to kubernetes-sigs/org Oct 3, 2019
@raelga
Copy link
Member Author

raelga commented Oct 3, 2019

The PR has been updated with just the config/kubernetes-sigs/org.yaml addition.

Thank you @tashimi, @justaugustus, and @cblecker for the help!

@cblecker
Copy link
Member

cblecker commented Oct 3, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 69fe684 into kubernetes:master Oct 3, 2019
@raelga raelga mentioned this pull request Oct 3, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/usability Categorizes an issue or PR as relevant to SIG Usability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for raelga
5 participants