Add vincepri to Cluster API GCP repo admin / update maintainers #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @justinsb @timothysc |
k8s-ci-robot
added
sig/cluster-lifecycle
vincepri
force-pushed
the
add-vincepri-gcp
branch
from
6cf736b
to
54e02ee
Compare
Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
add-vincepri-gcp
branch
from
54e02ee
to
ed2a6c7
Compare
timothysc
reviewed
Sep 10, 2019
| - justinsb | ||
| - krousey |
There was a problem hiding this comment.
I haven't seen kris around in O(year+)
There was a problem hiding this comment.
I can update if necessary, this is copied from the repo's maintainer list
k8s-ci-robot
added
do-not-merge/hold
|
I'm great with adding @vincepri - thanks & welcome! On the removals, I'll ask the people but I suggest we should do them separately... /approve |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, timothysc, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano vincepri@vmware.com