Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require org members to be sorted #114

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Sep 24, 2018

/assign @cblecker @spiffxp @nikhiljindal

a) Do we want to enforce this (we already enforce the absence of duplicates)
b) Do we want to enforce case sensitive sorting?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2018
@spiffxp
Copy link
Member

spiffxp commented Sep 24, 2018

/lgtm
I am fine with this

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2018
@cblecker
Copy link
Member

Enforcing sorting: 👍
Enforcing case sensitive sorting: 👎

Main thought behind that, is the dump from peribolos doesn't dump in case sensitive sorting (I'm guessing that's simply the way GitHub returns results). We also "normalize" case in a lot of places, so I'd like to ignore case wherever possible.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2018
@fejta
Copy link
Contributor Author

fejta commented Sep 24, 2018

PTAL, now require sorting to be case insensitive

@cblecker
Copy link
Member

/lgtm
/approve
/hold

🎉 🚀 🚢

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2018
@nikhita
Copy link
Member

nikhita commented Sep 24, 2018

/unassign @nikhiljindal

lgtm 👍

@fejta
Copy link
Contributor Author

fejta commented Sep 24, 2018

/joke

@k8s-ci-robot
Copy link
Contributor

@fejta: A Skeleton walked into a bar he said I need a beer and a mop

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta
Copy link
Contributor Author

fejta commented Sep 24, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5377856 into kubernetes:master Sep 24, 2018
@fejta fejta deleted the sort branch September 24, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants