-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require org members to be sorted #114
Conversation
/lgtm |
Enforcing sorting: 👍 Main thought behind that, is the dump from peribolos doesn't dump in case sensitive sorting (I'm guessing that's simply the way GitHub returns results). We also "normalize" case in a lot of places, so I'd like to ignore case wherever possible. |
PTAL, now require sorting to be case insensitive |
/lgtm 🎉 🚀 🚢 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unassign @nikhiljindal lgtm 👍 |
/joke |
@fejta: A Skeleton walked into a bar he said I need a beer and a mop In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/assign @cblecker @spiffxp @nikhiljindal
a) Do we want to enforce this (we already enforce the absence of duplicates)
b) Do we want to enforce case sensitive sorting?