Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members 2019-07-17 #1017

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Add members 2019-07-17 #1017

merged 1 commit into from
Jul 25, 2019

Conversation

ezzoueidi
Copy link
Contributor

Fixes #1014

/area github-membership

@k8s-ci-robot k8s-ci-robot added area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jul 17, 2019
@ezzoueidi ezzoueidi mentioned this pull request Jul 17, 2019
Closed
6 tasks
@ezzoueidi
Copy link
Contributor Author

Both sponsors are from VMware, holding this PR until another +1 from non-VMware sponsor.
Thanks @mrbobbytables for catching this :D
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2019
@rjbez17
Copy link
Contributor

rjbez17 commented Jul 19, 2019 •
edited
Loading

+1 from me

@justaugustus
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 19, 2019
@justaugustus justaugustus mentioned this pull request Jul 23, 2019
Merged
@nikhita
Copy link
Member

nikhita commented Jul 23, 2019

/hold
for second non-vmware sponsor

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 23, 2019
@cblecker
Copy link
Member

@nzoueidi can you please rebase instead of using a merge commit?

@ezzoueidi
Copy link
Contributor Author

@cblecker looks like there is a conflict when I rebase on top of master. I will resolve it when am at home.

@mrbobbytables
Copy link
Member

/hold cancel

\o/

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2019
@mrbobbytables
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, nzoueidi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9adb051 into kubernetes:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for runyontr
7 participants
@ezzoueidi @rjbez17 @justaugustus @nikhita @cblecker @mrbobbytables @k8s-ci-robot