Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: create kube-scheduler-wasm-extension #4174

Closed
sanposhiho opened this issue Apr 24, 2023 · 19 comments · Fixed by kubernetes/community#7297
Closed

REQUEST: create kube-scheduler-wasm-extension #4174

sanposhiho opened this issue Apr 24, 2023 · 19 comments · Fixed by kubernetes/community#7297
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Apr 24, 2023

New repo, staging repo, or migrate existing

new repo

Is it a staging repo?

no

Requested name for new repository

kube-scheduler-wasm-extension

Which Organization should it reside

kubernetes-sigs

Who should have admin access?

sanposhiho, kerthcet

Who should have write access?

sanposhiho, kerthcet

Who should be listed as approvers in OWNERS?

sanposhiho, kerthcet

Who should be listed in SECURITY_CONTACTS?

sanposhiho, kerthcet

What should the repo description be?

All the things to make the scheduler extendable with wasm.

What SIG and subproject does this fall under?

sig-scheduling

Please provide references to appropriate approval for this new repo

#4174 (comment)

Additional context for request

kubernetes/kubernetes#112851

Past context. No longer needed to read.

the previous discussion thread: https://kubernetes.slack.com/archives/C09TP78DV/p1676610114431299

What we need to have:

  • ABI design documentation.
    • We need to have the documentation how the scheduler plugin(host) communicates with the wasm binary(guest) (= Application Binary Interface (ABI)). Something like this. It's important so that not only us, but anyone can create the guest (or SDK) based on the ABI.
  • The scheduler plugin to host wasm runtime.
  • The SDK(s) to build the wasm binary.
    • It's impossible to require users to build the wasm binary by themselves without any guides. So, in most cases, developers provides the SDK like this so that people can easily build the wasm binary which follows ABI. We can start with Golang SDK, but we may want to have the SDK in other languages in the future.

We have two options on the table:


I'm +1 on the idea to create the new repository because it requires not only implementing scheduler plugin, but also many other stuff, unlike other scheduler plugins developed in sigs/scheduler-plugins.


@kubernetes/sig-scheduling-leads Please take a look and give any comments on it. 🙏 I'd like to move this stuck discussion forward.

@sanposhiho sanposhiho added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Apr 24, 2023
@alculquicondor
Copy link
Member

Can we discuss this in a SIG meeting?
My initial reaction is that the SIG already has too many subprojects and I don't see a strong justification to not have it in scheduler-plugins

@sanposhiho
Copy link
Member Author

Can we discuss this in a SIG meeting?

Sure. Please add it to discussion item.
Let's see other members opinion.

@alculquicondor
Copy link
Member

Added

@alculquicondor
Copy link
Member

@sanposhiho, here are some guidelines about subprojects:

In addition to them, I would like to request an update on the SIG scheduling meeting at least once every 4 months, from any of the subproject owners. I hope we could ask the same to other subprojects.

@Huang-Wei
Copy link
Member

In addition to them, I would like to request an update on the SIG scheduling meeting at least once every 4 months

+1.

@sanposhiho
Copy link
Member Author

Apologize for missing the meeting.
And, @alculquicondor thanks for bringing this topic in sig meeting. 🙇

So, the conclusion on the sig meeting is to go with creating new repo?

an update on the SIG scheduling meeting at least once every 4 months

Sure, I can provide updates. (simulator as well)

@alculquicondor
Copy link
Member

Thanks!
+1 for the repo creation

@sanposhiho sanposhiho changed the title WIP: REQUEST: create kube-scheduler-wasm-extension REQUEST: create kube-scheduler-wasm-extension May 9, 2023
@sanposhiho
Copy link
Member Author

I'd like to have more maintainers (at least, one more reviewer is required; otherwise I cannot submit PR)

@kubernetes/sig-scheduling-misc Is anyone interested in it?

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label May 9, 2023
@Huang-Wei
Copy link
Member

I'd +1 to support this repo's creation, but I'm out of bandwidth to participating as a reviewer/maintainer :(

@sanposhiho
Copy link
Member Author

Hmm, I believe the wazero maintainers will help review from wasm side PoV, but I guess no one has membership in this org.
So, I hope someone from sig-scheduling can take on reviewer though... 😞

@alculquicondor
Copy link
Member

you could ask in the mailing list, but ideally it should be someone that is already a reviewer in another subproject.

@codefromthecrypt
Copy link

wazero folks can help review unofficially even if not in the org. Please feel free to ping me.

@kerthcet
Copy link
Member

@sanposhiho I can help with this from scheduling POV, our company met tricky issue as both our company and our customers have specific plugins but we can't compile them together for security reasons, we're searching for solutions like go plugin and wasm.

@sanposhiho
Copy link
Member Author

@kerthcet Great. Thanks! 😭

@Huang-Wei
Copy link
Member

Thanks @kerthcet !

@salaboy
Copy link

salaboy commented May 12, 2023

+1 for the repo creation

@kerthcet
Copy link
Member

kindly ping @nikhita @mrbobbytables as we want to push forward the process. Thanks a lot.

@nikhita
Copy link
Member

nikhita commented May 16, 2023

/assign

Repo has been created - https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension 🎉

Also created:

Once both PRs merge, we can close this issue.

@salaboy
Copy link

salaboy commented May 16, 2023

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants