Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Kui repo to kubernetes-sigs #2461

Closed
paulcastro opened this issue Jan 25, 2021 · 28 comments
Closed

Move Kui repo to kubernetes-sigs #2461

paulcastro opened this issue Jan 25, 2021 · 28 comments
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Milestone

Comments

@paulcastro
Copy link

paulcastro commented Jan 25, 2021

New Repo, Staging Repo, or migrate existing

Change ownership of existing repo from github.com/IBM

Requested name for new repository

  • kubernetes-sigs/kui

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

  • starpit
  • myan9

If not a staging repo, who should have write access

  • team: sig-cli-maintainers
  • team: kui-maintainers

If not a staging repo, who should be listed as approvers in OWNERS

  • starpit
  • myan9
  • mark-nc

If not a staging repo, who should be listed in SECURITY_CONTACTS

  • starpit
  • myan9
  • mark-nc

What should the repo description be

A hybrid command-line/UI development experience for cloud-native development

What SIG and subproject does this fall under in sigs.yaml

this is a subproject for sig-cli called Kui

Approvals

The sig-cli already tracks kui as a subproject as described in this KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/2257-kui

Additional context for request

  • We assume we can update sigs.yaml after repo creation?

/cc @soltysh @starpit

@paulcastro paulcastro added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Jan 25, 2021
@nikhita
Copy link
Member

nikhita commented Jan 27, 2021

/sig cli

/assign @soltysh @eddiezane @pwittrock
for approval

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jan 27, 2021
@soltysh
Copy link
Contributor

soltysh commented Jan 28, 2021

👍 from my end, I'm positive that other leads are on -board since this was discussed during sig-cli multiple times in the past.

@nikhita
Copy link
Member

nikhita commented Jan 28, 2021

@soltysh thanks for the ack!

@paulcastro since the repo needs to be migrated, can you ensure that the repo meets the requirements listed here - https://github.com/kubernetes/community/blob/master/github-management/kubernetes-repositories.md#rules-for-donated-repositories?

Once that's done, please ping me here again and I can help with the migration. :)

@pwittrock
Copy link
Member

+1

@starpit
Copy link

starpit commented Jan 29, 2021

@nikhita Thanks for the help! I think we have all of the rules engaged with the following exceptions:

  1. the CLA bot is set up, but we are still waiting for @thelinuxfoundation to accept the user invitation; this is needed to fully enable the bot

  2. prow: is my understanding correct that we will need to find a cluster to host this? or is their provision for piggybacking multiple projects onto a single prow?

@nikhita
Copy link
Member

nikhita commented Feb 1, 2021

the CLA bot is set up, but we are still waiting for @thelinuxfoundation to accept the user invitation; this is needed to fully enable the bot

@starpit -- the linuxfoundation bot will not accept the invitation. Once the repo is migrated over, CLA checks will automatically be enabled on all PRs.

prow: is my understanding correct that we will need to find a cluster to host this? or is their provision for piggybacking multiple projects onto a single prow?

A single prow instance is used for all k8s projects. https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md has more details on how to use it.


@starpit @paulcastro There are few more things we need to get out of the way before we can migrate the repo.

Note: if your name is listed above, could you please sign the CNCF CLA so that we can migrate the Kui repo to Kubernetes? Instructions on how to sign the CLA can be found here. Thank you! :)


@starpit @paulcastro We'll need to wait for a few weeks to see if any of the folks listed below sign the CLA. If there are outliers who have not signed the CLA, you can either:

  1. remove the file if that's possible - Migrate krew & krew-index to kubernetes-sigs #599 (comment)
  2. add a NOTICE file - Migrate DirectXMan12/k8s-prometheus-adapter to kubernetes-sigs #2182 (comment)

@joshuaauerbachwatson
Copy link

Hi. I am listed as someone who needs to sign a new CLA. I long ago stopped being an active contributor to the kui core and would prefer not to go through these additional steps if it can be avoided. It sounds like you can just delete me as a contributor.

@nikhita nikhita self-assigned this Feb 1, 2021
@LouisStAmour
Copy link

Signed :)

@abdonrd
Copy link

abdonrd commented Feb 4, 2021

Signed!

@ujibang
Copy link

ujibang commented Feb 4, 2021 via email

@jesusprubio
Copy link

Signed!

@myan9
Copy link

myan9 commented Feb 22, 2021

@nikhita, thanks for the help! We've done the Copyright header and Notice file. We're investigating on travis status check via prow. Currently Kui is using travis-ci for testing, so we want to configure prow to merge a PR when travis tests pass. Does the following configuration code against test-infra/config/prow/config.yaml look good to you? Does required_status_checks mean that prow will check the travis test result as long as the repo is travis enabled? We looked a couple of repos that specify travis status check in the config.yaml, but somehow prow merge PRs even if those repo no longer use travis. That's why we're a bit confused... Thank you!

  kui:
       required_status_checks:
           contexts:
           - continuous-integration/travis-ci

@nikhita
Copy link
Member

nikhita commented Feb 23, 2021

Does the following configuration code against test-infra/config/prow/config.yaml look good to you?

Yes, this looks good!

Does required_status_checks mean that prow will check the travis test result as long as the repo is travis enabled? We looked a couple of repos that specify travis status check in the config.yaml, but somehow prow merge PRs even if those repo no longer use travis.

Yes, as long as travis is enabled in your repo and you specify required_status_checks in config.yaml, PRs will merge only if the travis check is green.

As a project, we encourage writing prow jobs instead of using travis so I'd recommend looking at migrating to prow entirely. You can find the docs here.

@myan9
Copy link

myan9 commented Feb 23, 2021

@nikhita, thanks for the clarification! We'll continue the prow work once the PR is merged. We just finished the last round of cleaning up Copyright headers. Could you check if we're g2g? Thanks a lot!

@nikhita
Copy link
Member

nikhita commented Feb 24, 2021

@myan9 just a few more things, sorry :(

@swinslow
Copy link

@nikhita 👋

One thing I note looking at the contributors listed above (setting aside those who have signed since then) is that several appear to work for existing k8s contributors like IBM, Red Hat and VMware. If someone from those companies can confirm here that their contributions can be treated as covered under those companies' existing signed CNCF CLAs, that would take care of them.

For the remainder, if there isn't a path forward to getting them to sign the CLA, then yes, I believe the project's practice is to include a NOTICE file with the language that was used recently for another repo in a similar situation.

@starpit
Copy link

starpit commented Mar 10, 2021

@swinslow thanks for the help. We have I think a final list of CLA non-signers, and have added them to a NOTICE file as follows:

Submitted on behalf of a third-party: ImgBotApp “ImgBotApp”
Submitted on behalf of a third-party: Joshua “joshuaauerbachwatson” Auerbach
Submitted on behalf of a third-party: Yeray “ydarias” Darias
Submitted on behalf of a third-party: Darío “kant” Hereñú
Submitted on behalf of a third-party: Nirvana “nirvana-flam” Flame

In terms of contributions:

  1. these are simple image optimizations, to reduce the size of files, and done by an automated bot
  2. these contributions amount to a few lines of code that create a file if the thus-named file does not yet exist
  3. are to .github template files, e.g. for new bug/new issue
    4 and 5) minor changes to the README.md

Will the NOTICE file suffice for these? Thanks!

@spiffxp
Copy link
Member

spiffxp commented Mar 10, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 10, 2021
@swinslow
Copy link

Hi @starpit, yes, these sound like minor contributions, and given past practice I think it would be fine to proceed with listing them in the NOTICE file as you described. Thanks!

@nikhita
Copy link
Member

nikhita commented Mar 15, 2021

@starpit @myan9 @mark-nc can you create an issue to apply for membership to the @kubernetes-sigs GitHub org? Only members can approve PRs once the repo has been migrated. Instructions are here - https://github.com/kubernetes/community/blob/master/community-membership.md#member

I think we're good to go after that 👍

@mark-nc
Copy link

mark-nc commented Mar 15, 2021

@nikhita Do we open one PR for all three of us, or one PR for each? The link you provided also mentions @-ing two sponsors in the PR. Who are our sponsors?

@mark-nc
Copy link

mark-nc commented Mar 15, 2021

Never mind.....discussed this with @starpit

@starpit
Copy link

starpit commented Mar 23, 2021

Update: the three Kubernetes Memberships have been approved and accepted!

#2572
#2573
#2574

@nikhita
Copy link
Member

nikhita commented Mar 24, 2021

@starpit Yay! If you can add me as an admin to the IBM/kui repo, I can help migrate it to k-sigs. :)

@starpit
Copy link

starpit commented Mar 24, 2021

@nikhita done 👍

@nikhita
Copy link
Member

nikhita commented Mar 24, 2021

@starpit I still don't see the Settings tab for the kui repo (admins should be able to see this) 🤔

Edit: worked with @starpit on slack to fix this

@nikhita
Copy link
Member

nikhita commented Mar 24, 2021

Repo has been migrated - https://github.com/kubernetes-sigs/kui 🚀

@starpit @myan9 @mark-nc Thank you so much for your patience in getting this to the finish line!

I've also created two more PRs:

Once both PRs merge, we can close this issue.

@nikhita
Copy link
Member

nikhita commented Mar 24, 2021

All PRs have merged and teams have been granted access. Closing.

@nikhita nikhita closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Development

No branches or pull requests