Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify site request for Secrets Store CSI Driver #2303

Closed
aramase opened this issue Nov 2, 2020 · 9 comments
Closed

Netlify site request for Secrets Store CSI Driver #2303

aramase opened this issue Nov 2, 2020 · 9 comments
Assignees
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps

Comments

@aramase
Copy link
Member

aramase commented Nov 2, 2020

Repository

kubernetes-sigs/secrets-store-csi-driver

Project domain

secrets-store-csi-driver.sigs.k8s.io

NOTE: Must match domain request.
See subproject site request docs for more information:
http://git.k8s.io/community/github-management/subproject-site-requests.md#subproject-domain-request

Additional context for request

Any additional information or links to discussions regarding the request.
kubernetes-sigs/secrets-store-csi-driver#335
kubernetes-sigs/secrets-store-csi-driver#360

cc @ritazh

@aramase aramase added the area/github-integration Third-party integrations, webhooks, or GitHub Apps label Nov 2, 2020
@nikhita
Copy link
Member

nikhita commented Nov 5, 2020

@aramase Once the netlify site is created, it will try to deploy the master branch. Please get kubernetes-sigs/secrets-store-csi-driver#360 merged and I can then create the site so that the deploy works :)

@nikhita nikhita self-assigned this Nov 5, 2020
@nikhita
Copy link
Member

nikhita commented Nov 5, 2020

/unassign
/assign @mrbobbytables

Bob knows Netlify best :)

@k8s-ci-robot k8s-ci-robot assigned mrbobbytables and unassigned nikhita Nov 5, 2020
@mrbobbytables
Copy link
Member

Netlify has been configured, and the domain is set for.
https://kubernetes-sigs-secrets-store-csi-driver.netlify.app

You will need to open a PR adding the stecrets-store-csi-driver.k8s.io CNAME in the k8s.io repo 👍

Once that's merged, the site can finish being provisioned and ssl setup :)

@aramase
Copy link
Member Author

aramase commented Nov 5, 2020

Thank you @mrbobbytables. Opened PR kubernetes/k8s.io#1398 to add the CNAME.

@mrbobbytables
Copy link
Member

mrbobbytables commented Nov 7, 2020

DNS has been updated in netlify, you should be good to go to merge 👍

@aramase
Copy link
Member Author

aramase commented Nov 9, 2020

Thank you @mrbobbytables. We'll get the PR in the driver reviewed and merged.

@nikhita
Copy link
Member

nikhita commented Dec 8, 2020

👋 Are there any more outstanding items here? Can we close this issue?

@aramase
Copy link
Member Author

aramase commented Dec 9, 2020

There are no outstanding items. Thank you for helping set this up.

/close

@k8s-ci-robot
Copy link
Contributor

@aramase: Closing this issue.

In response to this:

There are no outstanding items. Thank you for helping set this up.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps
Projects
None yet
Development

No branches or pull requests

4 participants