Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Repository for Container Object Storage Interface implementation #1942

Closed
brahmaroutu opened this issue Jun 18, 2020 · 15 comments
Closed
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@brahmaroutu
Copy link

brahmaroutu commented Jun 18, 2020

New Repo, Staging Repo, or migrate existing

new repository

Requested name for new repository

container-object-storage-interface-spec (Container Object Storage Specification)
container-object-storage-interface-csi-adapter (CSI driver to bootstrap COSI workloads)

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

@jsafrane
@msau42
@saad-ali
@xing-yang

If not a staging repo, who should have write access

@saad-ali
@jsafrane
@msau42
@xing-yang
@copejon
@wlan0
@brahmaroutu

If not a staging repo, who should be listed as approvers in OWNERS

@jsafrane
@msau42
@saad-ali
@xing-yang

If not a staging repo, who should be listed in SECURITY_CONTACTS

@jsafrane
@msau42
@saad-ali
@xing-yang

What should the repo description be

Kubernetes specific Container Object Storage Interface (COSI) components

What SIG and subproject does this fall under in sigs.yaml

this is a new subproject for sig-storage called kubernetes-cosi

Approvals

Please prove you have followed the appropriate approval process for this new
repo by including links to the relevant approvals (meeting minutes, e-mail
thread, etc.)

Need sig-storage approval from: @saad-ali and @xing-yang

Please refer to KEP: kubernetes/enhancements#1383

Authoritative requirements are here: https://git.k8s.io/community/github-management/kubernetes-repositories.md

tl;dr (but really you should read the linked doc, this may be stale)

  • If this is a core repository, then sig-architecture must approve
  • If this is a SIG repository, then this must follow the procedure spelled out
    in that SIG's charter

Additional context for request

Since the design mentioned in the KEP constitute multiple components, this issue is requesting for multiple repos under new subproject(Kubernetes-cosi) that belongs to sig-storage.

@brahmaroutu brahmaroutu added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Jun 18, 2020
@brahmaroutu
Copy link
Author

/assign @saad-ali

@brahmaroutu
Copy link
Author

/sig storage
/assign @xing-yang
ping @copejon @wlan0 Please review.

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 18, 2020
@copejon
Copy link

copejon commented Jun 18, 2020

WRT to

"including links to the relevant approvals (meeting minutes, e-mail
thread, etc.)"

See too #1904

@xing-yang
Copy link
Contributor

Can you send an email to sig-storage mailing list about this request?
Other than that, this looks good to me.

@brahmaroutu
Copy link
Author

Can you send an email to sig-storage mailing list about this request?
Other than that, this looks good to me.

thanks. I just sent out email about the request.

@saad-ali
Copy link
Member

Suggestions:

  • For repo names, spell out container-object-storage-interface rather than using abbreviation COSI
  • Align naming with CSI repos where possible, to lower cognitive overhead.
  • Start with just the spec and adapter repos, and wait to create the other repos until the architecture is finalized (do we want one sidecar or more? will there be one central controller? what will be the separation of between controllers and sidecars? etc.)
  • So:
    • cosi-grpc-interface -> container-object-storage-interface-spec
    • cosi-csi-driver -> container-object-storage-interface-csi-adapter (CSI driver to bootstrap COSI workloads)
    • cosi-controller-> Drop for now
    • cosi-sidecar-controller -> Drop for now

@copejon
Copy link

copejon commented Jun 19, 2020

cosi-controller-> Drop for now
cosi-sidecar-controller -> Drop for now

@saad-ali While we haven't hammered out a complete design for automation, it would still be beneficial to have a common space for prototyping. Is this work something we should handle out of band?

@saad-ali
Copy link
Member

I guess my concern is are you boxing yourself in by having a single repo called cosi-controller and cosi-sidecar-controller. Are you going to want more then one COSI controller or sidecar in the future (given that CSI has more than one sidecar)?

@copejon
Copy link

copejon commented Jun 19, 2020

Fair point, I think we'd be fine then with your suggested repos, with the architecture to follow once the design is settled on:

  1. container-object-storage-interface-spec
  2. container-object-storage-interface-csi-adapter

@brahmaroutu
Copy link
Author

I have updated the issue and I believe this will give us the start we need right now.
Please review and approve @saad-ali

@saad-ali
Copy link
Member

/lgtm
/approve

@nikhita
Copy link
Member

nikhita commented Jun 24, 2020

/assign

@nikhita
Copy link
Member

nikhita commented Jun 25, 2020

The repos have been created:

Also created:

Once both PRs merge, we can close this issue.

@nikhita
Copy link
Member

nikhita commented Jul 2, 2020

All PRs have merged :)

/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closing this issue.

In response to this:

All PRs have merged :)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Development

No branches or pull requests

6 participants