Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask to create sig-windows-samples repo in kubernetes-sigs #1853

Closed
michmike opened this issue May 5, 2020 · 7 comments
Closed

ask to create sig-windows-samples repo in kubernetes-sigs #1853

michmike opened this issue May 5, 2020 · 7 comments
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/windows Categorizes an issue or PR as relevant to SIG Windows.

Comments

@michmike
Copy link
Contributor

michmike commented May 5, 2020

New Repo, Staging Repo, or migrate existing

new repository

Requested name for new repository

sig-windows-samples

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

michmike, marosset

If not a staging repo, who should have write access

michmike, marosset

If not a staging repo, who should be listed as approvers in OWNERS

michmike, marosset

If not a staging repo, who should be listed in SECURITY_CONTACTS

michmike, marosset

What should the repo description be

Repository for samples and examples related to the sig-windows charter in Kubernetes.

What SIG and subproject does this fall under in sigs.yaml

This is a new repo for SIG-Windows.

Approvals

Mark and I are the sig co-chairs

Authoritative requirements are here: https://git.k8s.io/community/github-management/kubernetes-repositories.md

tl;dr (but really you should read the linked doc, this may be stale)

  • If this is a core repository, then sig-architecture must approve
  • If this is a SIG repository, then this must follow the procedure spelled out
    in that SIG's charter

Additional context for request

Any additional information or context to describe the request.

@michmike michmike added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label May 5, 2020
@nikhita
Copy link
Member

nikhita commented May 11, 2020

@michmike Sorry for the delayed response! From the SIG Windows meeting notes (5/5/2020), it mentions that this repo will contain code migrated from https://github.com/PatrickLang/fabrikamfiber.

We have different requirements for repo migration vs starting a new repo from scratch - https://github.com/kubernetes/community/blob/master/github-management/kubernetes-repositories.md#rules-for-donated-repositories. Can you clarify if this repo will contain migrated code? Thanks!

@nikhita nikhita self-assigned this May 11, 2020
@nikhita nikhita added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label May 11, 2020
@michmike
Copy link
Contributor Author

@nikhita , this repo would contain both new samples as well as existing samples that sig-windows is creating (or has created). Patrick was the sig-windows lead in the past and created that work as part of sig-windows. since there was no repo to put them, he used his own account.

@PatrickLang
Copy link

Hi @nikhita - that repo has many samples in it that I don't want to migrate because they're out of date or superceded by other docs. Our goal here is to bring in just the portions that are still relevant rather than the full repo.

@nikhita
Copy link
Member

nikhita commented May 12, 2020

@michmike @PatrickLang thanks for the context! I have created the repo - https://github.com/kubernetes-sigs/sig-windows-samples :)

Also created:

Once both PRs merge, we can close this issue.

@michmike
Copy link
Contributor Author

thank you!

@nikhita
Copy link
Member

nikhita commented May 12, 2020

Teams have been granted access and sigs.yaml has been updated

/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closing this issue.

In response to this:

Teams have been granted access and sigs.yaml has been updated

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Projects
None yet
Development

No branches or pull requests

4 participants