Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website-maintainers team doesn't have write permission #1436

Closed
cstoku opened this issue Nov 21, 2019 · 10 comments
Closed

website-maintainers team doesn't have write permission #1436

cstoku opened this issue Nov 21, 2019 · 10 comments
Assignees
Labels
area/github-permissions Permissions requests and problems sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@cstoku
Copy link
Contributor

cstoku commented Nov 21, 2019

Organization or repository

Kubernetes/website-maintainers
kubernetes/website

Users affected

Users who belong to the website-maintainers team

Describe the issue

This team doesn't have k/website write permission.
This makes it impossible to create a branch.

@rlenferink
Copy link
Member

rlenferink commented Nov 21, 2019

/cc @zacharysarah
/cc @nikhita @mrbobbytables

Ref. #1375

@gochist
Copy link
Member

gochist commented Nov 22, 2019

This blocks finishing Korean l10n team milestone dev-1.16-ko.5 and starting dev-1.16-ko.6.

@justaugustus
Copy link
Member

/assign @cblecker

@justaugustus
Copy link
Member

(Just a heads up that a bunch of the @kubernetes/owners team is at KubeCon, so this may take a little bit.)

@nikhita
Copy link
Member

nikhita commented Nov 22, 2019

Granted website-maintainers write access to the repo.

@zacharysarah I noticed that sig-docs-maintainers also had write access. Two questions:

  1. Should write access be revoked from this team?

  2. Do we still need this team now that we have website-maintainers, website-admins and language specific teams?

@nikhita
Copy link
Member

nikhita commented Dec 4, 2019

/unassign @cblecker
/assign @zacharysarah @jimangel @Bradamant3

@nikhita nikhita added area/github-permissions Permissions requests and problems sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 4, 2019
@zacharysarah
Copy link

@nikhita 👋 Thanks for your patience.

I noticed that sig-docs-maintainers also had write access. Two questions:

  • Should write access be revoked from this team?

Yes.

  • Do we still need this team now that we have website-maintainers, website-admins and language specific teams?

No.

I'll open a separate PR to remove the team. Thanks, @nikhita, for surfacing the concern! 🙇

@zacharysarah
Copy link

zacharysarah commented Dec 9, 2019

@gochist To be clear, you should have write access now. Do you have what you need?

EDIT: @gochist Feel free to /reopen this issue if you're still blocked by write permissions.

@zacharysarah
Copy link

fixed by #1375

/close

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Closing this issue.

In response to this:

fixed by #1375

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-permissions Permissions requests and problems sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

No branches or pull requests

10 participants