Skip to content

Conversation

@jeremyje
Copy link
Contributor

@jeremyje jeremyje commented Feb 9, 2021

Development documentation for #461.

Signed-off-by: Jeremy Edwards 1312331+jeremyje@users.noreply.github.com

This change depends on: #517

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2021
@jeremyje
Copy link
Contributor Author

jeremyje commented Feb 9, 2021

/sig windows

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Feb 9, 2021
@jeremyje
Copy link
Contributor Author

jeremyje commented Feb 9, 2021

/retest

Signed-off-by: Jeremy Edwards <1312331+jeremyje@users.noreply.github.com>
@jeremyje
Copy link
Contributor Author

/retest

@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyje, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2021
@vteratipally
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit adf4c72 into kubernetes:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants