Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue https://github.com/kubernetes/node-problem-detector/issues/471 #472

Closed
wants to merge 1 commit into from
Closed

Conversation

vteratipally
Copy link
Collaborator

Removing the labels fstype and options as the disk_bytes_used metric should report only size

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @vteratipally. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2020
@vteratipally
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@vteratipally: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vteratipally
Copy link
Collaborator Author

vteratipally commented Oct 8, 2020

/assign @bsdnet

1 similar comment
@vteratipally
Copy link
Collaborator Author

/assign @bsdnet

@bsdnet
Copy link

bsdnet commented Oct 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@vteratipally
Copy link
Collaborator Author

/assign @Random-Liu

@vteratipally
Copy link
Collaborator Author

/assign @wangzhen127

@wangzhen127
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2020
@wangzhen127
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsdnet, vteratipally, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@vteratipally
Copy link
Collaborator Author

/test pull-npd-e2e-node

@vteratipally
Copy link
Collaborator Author

#467

@vteratipally
Copy link
Collaborator Author

/test pull-npd-e2e-node

@vteratipally
Copy link
Collaborator Author

/retest

@vteratipally
Copy link
Collaborator Author

/test pull-npd-e2e-node

@vteratipally
Copy link
Collaborator Author

/retest

@vteratipally
Copy link
Collaborator Author

/test pull-npd-e2e-node

@k8s-ci-robot
Copy link
Contributor

@vteratipally: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-npd-e2e-node 5fdfb1d link /test pull-npd-e2e-node

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants