Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return an error when error happens in SetConditions() #134

Merged
merged 1 commit into from
Aug 23, 2017
Merged

return an error when error happens in SetConditions() #134

merged 1 commit into from
Aug 23, 2017

Conversation

CaoShuFeng
Copy link
Contributor

@CaoShuFeng CaoShuFeng commented Aug 23, 2017 •
edited by k8s-reviewable
Loading

@Random-Liu

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 23, 2017
@CaoShuFeng
Copy link
Contributor Author

/assign @Random-Liu

@Random-Liu
Copy link
Member

My mistake, thanks for fixing!

@Random-Liu Random-Liu added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2017
@Random-Liu Random-Liu merged commit c0bd1df into kubernetes:master Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Random-Liu Random-Liu

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaoShuFeng @Random-Liu @k8s-ci-robot