-
Notifications
You must be signed in to change notification settings - Fork 682
Update Go to v1.24.10 for release-1.34 #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.34
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d359d35 to
092e6e9
Compare
|
/retest |
|
change lgtm what is the motivation? Some CVE? |
|
Test fails with cgroupv1 error: This is strange as I have added this flag: https://github.com/kubernetes/test-infra/blob/f89f8b76ce46e8f1e9c70cba16e4d2cbdd347e98/config/jobs/kubernetes/node-problem-detector/node-problem-detector-presubmits.yaml#L319 |
|
maybe it was the wrong way to set the flag. I will try to find time to investigate later |
|
@SergeyKanzhelev let's merge an iterate on the flag separately. |
Yes... someone pinged me and asked for a bump. |
|
Looks like we may heed something like kubernetes/test-infra#35907 merged first. |
|
/retest |
|
@hakman: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cc @SergeyKanzhelev @wangzhen127