Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --extra-config when starting an existing cluster #9634

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Fix --extra-config when starting an existing cluster #9634

merged 1 commit into from
Dec 9, 2020

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Nov 8, 2020 •
edited
Loading

Fixes #8242

Creating a minikube cluster with minikube start no arguments results in null value for ExtraOptions in .minikube/profiles/minikube/config.json:

        "ExtraOptions": null,

If we then stop and start minikube a second time with minikube start --extra-config=apiserver.enable-admission-plugins=NamespaceAutoProvision the ExtraOptions in the config file stays the same and in the cluster the apiserver config also doesn't change:

$ ps auxwf | grep -v grep | grep -o -- '--enable-admission[^ ]*'
--enable-admission-plugins=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota

Doing the same thing with my patch the ExtraOptions in the profile will change to:

                "ExtraOptions": [
                        {
                                "Component": "apiserver",
                                "Key": "enable-admission-plugins",
                                "Value": "NamespaceAutoProvision"
                        }
                ],

And if we look in the cluster we see the config has been applied this time:

$ ps auxwf | grep -v grep | grep -o -- '--enable-admission[^ ]*'
--enable-admission-plugins=NamespaceAutoProvision

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @dekkers!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dekkers. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Nov 8, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@TravisBuddy
Copy link

Travis tests have failed

Hey @dekkers,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test 
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.14.2 -X k8s.io/minikube/pkg/version.isoVersion=v1.14.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="62e5f6518e242366eb94ea56885136c84994d0d8" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
cmd/minikube/cmd/start_flags.go:615: File is not `goimports`-ed (goimports)
		cc.KubernetesConfig.ExtraOptions = config.ExtraOptions;
Makefile:434: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:315: recipe for target 'test' failed
make: *** [test] Error 4
travis_time:end:083de1dc:start=1604847092612385963,finish=1604847317839761841,duration=225227375878,event=script

2nd Build

View build log

make test 
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.14.2 -X k8s.io/minikube/pkg/version.isoVersion=v1.14.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="62e5f6518e242366eb94ea56885136c84994d0d8" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading k8s.io/client-go v0.17.3
go: downloading k8s.io/apimachinery v0.17.3
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading k8s.io/kubernetes v1.18.5
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200902152226-fbad78ec2813
go: downloading golang.org/x/crypto v0.0.0-20200820211705-5c72a883971a
go: downloading k8s.io/api v0.17.3
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading k8s.io/klog v1.0.0
go: downloading k8s.io/klog/v2 v2.4.0
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20201020145846-c0da14b4bffe
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/google/gofuzz v1.1.0
go: downloading github.com/fatih/color v1.9.0
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/hashicorp/go-version v1.2.1
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/docker/go-connections v0.4.0
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/google/go-github v17.0.0+incompatible
go: downloading google.golang.org/protobuf v1.24.0
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/go-logr/logr v0.3.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/google/go-querystring v1.0.0
go: downloading google.golang.org/grpc v1.29.1
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading sigs.k8s.io/yaml v1.2.0
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/magiconair/properties v1.8.1
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/spf13/afero v1.2.2
go: downloading k8s.io/kube-openapi v0.0.0-20200410145947-61e04a5be9a6
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/google/go-cmp v0.5.2
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/beorn7/perks v1.0.1
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
--- FAIL: TestGenerateDocs (0.03s)
    --- FAIL: TestGenerateDocs/addons (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 17 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for addons
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for configure
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for disable
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 17 identical lines
              	
              	Enables the addon w/ADDON_NAME within minikube (example: minikube addons enable dashboard). For a list of available addons use: minikube addons list 
            - 	
            - 	```
            - 	minikube addons enable ADDON_NAME [flags]
            - 	```
            - 	
            - 	### Options
              	... // 132 identical, 15 removed, and 11 inserted lines
              	"""
              )
    --- FAIL: TestGenerateDocs/cache (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 13 identical lines
              	Add, delete, or push a local image into minikube
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for cache
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for add
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for delete
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 15 identical lines
              	
              	### Synopsis
            - 	
            - 	Help provides help for any command in the application.
            - 	Simply type cache help [path to command] for full details.
            - 	
            - 	```
            - 	minikube cache help [command] [flags]
            - 	```
              	... // 92 identical, 14 removed, and 11 inserted lines
              	"""
              )
    --- FAIL: TestGenerateDocs/completion (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 38 identical lines
              	```
              	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for completion
            - 	```
            - 	
              	### Options inherited from parent commands
              	
              	... // 2 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/config (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 47 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for config
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 28 identical lines
              	
              	```
            - 	  -h, --help            help for defaults
              	      --output string   Output format. Accepted values: [json]
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for get
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 23 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for help
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 15 identical lines
              	
              	### Synopsis
            - 	
            - 	Sets the PROPERTY_NAME config value to PROPERTY_VALUE
            - 		These values can be overwritten by flags or environment variables at runtime.
            - 	
            - 	```
            - 	minikube config set PROPERTY_NAME PROPERTY_VALUE [flags]
            - 	```
              	... // 92 identical, 14 removed, and 11 inserted lines
              	"""
              )
    --- FAIL: TestGenerateDocs/dashboard (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   strings.Join({
              	... // 20 identical lines
              	"",
              	"```",
            - 	"  -h, --help   help for dashboard",
            - 	"      --url    Display dashboard URL instead of opening a browser",
            + 	"      --url   Display dashboard URL instead of opening a browser",
              	"```",
              	"",
              	... // 4 identical lines
              	"      --alsologtostderr                  log to standard error as well as files",
              	`  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")`,
            + 	"  -h, --help                             ",
              	"      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)",
              	"      --log_dir string                   If non-empty, write log files in this directory",
              	... // 13 identical lines
              }, "\n")
    --- FAIL: TestGenerateDocs/delete (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 22 identical lines
              	```
              	      --all     Set flag to delete all profiles
            - 	  -h, --help    help for delete
              	      --purge   Set this flag to delete the '.minikube' folder from your user directory.
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/docker-env (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 20 identical lines
              	
              	```
            - 	  -h, --help           help for docker-env
              	      --no-proxy       Add machine IP to NO_PROXY environment variable
              	      --shell string   Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect
              	... // 7 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/ip (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 17 identical lines
              	```
              	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for ip
            - 	```
            - 	
              	### Options inherited from parent commands
              	
              	... // 2 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/kubectl (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 21 identical lines
              	```
              	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for kubectl
            - 	```
            - 	
              	### Options inherited from parent commands
              	
              	... // 2 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/logs (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 21 identical lines
              	```
              	  -f, --follow        Show only the most recent journal entries, and continuously print new entries as they are appended to the journal.
            - 	  -h, --help          help for logs
              	  -n, --length int    Number of lines back to go within the log (default 60)
              	      --node string   The node to get logs from. Defaults to the primary control plane.
              	... // 7 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/mount (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 22 identical lines
              	      --9p-version string   Specify the 9p version that the mount should use (default "9p2000.L")
              	      --gid string          Default group id used for the mount (default "docker")
            - 	  -h, --help                help for mount
              	      --ip string           Specify the ip that the mount should be setup on
              	      --kill                Kill the mount process spawned by minikube start
              	... // 11 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/node (0.01s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 17 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for node
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 27 identical lines
              	      --control-plane       If true, the node added will also be a control plane in addition to a worker.
              	      --delete-on-failure   If set, delete the current cluster if start fails and try again. Defaults to false.
            - 	  -h, --help                help for add
              	      --worker              If true, the added node will be marked for work. Defaults to true. (default true)
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for delete
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 23 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for help
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 11 identical lines
              	
              	## minikube node list
            - 	
            - 	List nodes.
            - 	
            - 	### Synopsis
              	... // 94 identical, 17 removed, and 11 inserted lines
              	"""
              )
    --- FAIL: TestGenerateDocs/pause (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 22 identical lines
              	  -n, ----namespaces strings   namespaces to pause (default [kube-system,kubernetes-dashboard,storage-gluster,istio-operator])
              	  -A, --all-namespaces         If set, pause all namespaces
            - 	  -h, --help                   help for pause
              	  -o, --output string          Format to print stdout in. Options include: [text,json] (default "text")
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/podman-env (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 20 identical lines
              	
              	```
            - 	  -h, --help           help for podman-env
              	      --shell string   Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect
              	  -u, --unset          Unset variables instead of setting them
              	... // 6 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/profile (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 17 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for profile
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 15 identical lines
              	
              	### Synopsis
            - 	
            - 	Help provides help for any command in the application.
            - 	Simply type profile help [path to command] for full details.
            - 	
            - 	```
            - 	minikube profile help [command] [flags]
            - 	```
              	
            - 	### Options
            + 	Help provides help for any command in the application.
            + 	Simply type profile help [path to command] for full details.
              	
              	```
            - 	  -h, --help   help for help
            + 	minikube profile help [command] [flags]
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 25 identical lines
              	
              	```
            - 	  -h, --help            help for list
              	  -o, --output string   The output format. One of 'json', 'table' (default "table")
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/service (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 21 identical lines
              	```
              	      --format string      Format to output service URL in. This format will be applied to each url individually and they will be printed one at a time. (default "http://{{.IP}}:{{.Port}}")
            - 	  -h, --help               help for service
              	      --https              Open the service URL with https instead of http (defaults to "false")
              	      --interval int       The initial time interval for each check that wait performs in seconds (default 1)
              	... // 9 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 23 identical lines
              	```
              	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for help
            - 	```
            - 	
              	### Options inherited from parent commands
              	
              	... // 3 identical lines
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
              	      --format string                    Format to output service URL in. This format will be applied to each url individually and they will be printed one at a time. (default "http://{{.IP}}:{{.Port}}")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 25 identical lines
              	
              	```
            - 	  -h, --help               help for list
              	  -n, --namespace string   The services namespace
              	```
              	... // 6 identical lines
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
              	      --format string                    Format to output service URL in. This format will be applied to each url individually and they will be printed one at a time. (default "http://{{.IP}}:{{.Port}}")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/ssh (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 20 identical lines
              	
              	```
            - 	  -h, --help          help for ssh
              	      --native-ssh    Use native Golang SSH client (default true). Set to 'false' to use the command line 'ssh' command when accessing the docker machine. Useful for the machine drivers when they will not start with 'Waiting for SSH'. (default true)
              	  -n, --node string   The node to ssh into. Defaults to the primary control plane.
              	... // 6 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/ssh-key (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 17 identical lines
              	```
              	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for ssh-key
            - 	```
            - 	
              	### Options inherited from parent commands
              	
              	... // 2 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/start (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 51 identical lines
              	      --force                             Force minikube to perform possibly dangerous operations
              	      --force-systemd                     If set, force the container runtime to use sytemd as cgroup manager. Currently available for docker and crio. Defaults to false.
            - 	  -h, --help                              help for start
              	      --host-dns-resolver                 Enable host resolver for NAT DNS requests (virtualbox driver only) (default true)
              	      --host-only-cidr string             The CIDR to be used for the minikube VM (virtualbox driver only) (default "192.168.99.1/24")
              	... // 45 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/status (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 24 identical lines
              	  -f, --format string   Go template format string for the status output.  The format for Go templates can be found here: https://golang.org/pkg/text/template/
              	                        For the list accessible variables for the template, see the struct values here: https://godoc.org/k8s.io/minikube/cmd/minikube/cmd#Status (default "{{.Name}}\ntype: Control Plane\nhost: {{.Host}}\nkubelet: {{.Kubelet}}\napiserver: {{.APIServer}}\nkubeconfig: {{.Kubeconfig}}\n\n")
            - 	  -h, --help            help for status
              	  -l, --layout string   output layout (EXPERIMENTAL, JSON only): 'nodes' or 'cluster' (default "nodes")
              	  -n, --node string     The node to check status for. Defaults to control plane. Leave blank with default format for status on all nodes.
              	... // 7 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/stop (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 21 identical lines
              	```
              	      --all                   Set flag to stop all profiles (clusters)
            - 	  -h, --help                  help for stop
              	      --keep-context-active   keep the kube-context active after cluster is stopped. Defaults to false.
              	  -o, --output string         Format to print stdout in. Options include: [text,json] (default "text")
              	... // 6 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/tunnel (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 21 identical lines
              	```
              	  -c, --cleanup   call with cleanup=true to remove old tunnels (default true)
            - 	  -h, --help      help for tunnel
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/unpause (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 22 identical lines
              	  -n, ----namespaces strings   namespaces to unpause (default [kube-system,kubernetes-dashboard,storage-gluster,istio-operator])
              	  -A, --all-namespaces         If set, unpause all namespaces
            - 	  -h, --help                   help for unpause
              	  -o, --output string          Format to print stdout in. Options include: [text,json] (default "text")
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/update-check (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 17 identical lines
              	```
              	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for update-check
            - 	```
            - 	
              	### Options inherited from parent commands
              	
              	... // 2 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/update-context (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 18 identical lines
              	```
              	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for update-context
            - 	```
            - 	
              	### Options inherited from parent commands
              	
              	... // 2 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/version (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 20 identical lines
              	
              	```
            - 	  -h, --help            help for version
              	  -o, --output string   One of 'yaml' or 'json'.
              	      --short           Print just the version number.
              	... // 6 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
E1108 14:53:24.114219   12042 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E1108 14:53:24.114652   12042 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E1108 14:53:24.114780   12042 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=localhost:3128 to docker env.
E1108 14:53:24.114953   12042 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=localhost:3128 to docker env.
E1108 14:53:24.115039   12042 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=http://localhost:3128 to docker env.
E1108 14:53:24.115200   12042 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=http://localhost:3128 to docker env.
E1108 14:53:24.115282   12042 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=http://127.0.0.1:3128 to docker env.
E1108 14:53:24.115439   12042 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=http://127.0.0.1:3128 to docker env.
FAIL
coverage: 18.5% of statements
FAIL	k8s.io/minikube/cmd/minikube/cmd	5.569s
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.043s	coverage: 21.0% of statements
ok  	k8s.io/minikube/pkg/addons	0.042s	coverage: 50.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.007s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.007s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.018s	coverage: 6.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.046s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.643s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.106s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.018s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.013s	coverage: 82.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.083s	coverage: 14.5% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.030s	coverage: 4.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.148s	coverage: 68.1% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.085s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.034s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.023s	coverage: 40.1% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.011s	coverage: 58.6% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.025s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.045s	coverage: 81.3% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.010s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.039s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.074s	coverage: 35.8% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.063s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.030s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.022s	coverage: 66.0% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.011s	coverage: 54.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.021s	coverage: 21.1% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/reason	0.008s	coverage: 80.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.010s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.080s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.003s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.047s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/style	0.005s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.029s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.007s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.950s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	1.125s	coverage: 75.7% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.006s	coverage: 22.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.003s	coverage: 0.0% of statements
FAIL
Makefile:315: recipe for target 'test' failed
make: *** [test] Error 32
travis_time:end:207ece6b:start=1604847088879181206,finish=1604847253331899765,duration=164452718559,event=script
TravisBuddy Request Identifier: 5963a250-21d3-11eb-a04c-b76cbd6ddda3

medyagh
medyagh reviewed Nov 9, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind putting the PR description before and after this PR and check if the extra-config actually goes through on an existing cluster?

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2020
priyawadhwa
priyawadhwa approved these changes Nov 30, 2020
View reviewed changes
Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's run the tests and make sure they pass

@priyawadhwa
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dekkers, priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@kubernetes kubernetes deleted a comment from minikube-pr-bot Nov 30, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 63.6s 59.5s 59.9s
Average time for minikube: 61.0s

Times for Minikube (PR 9634): 59.8s 61.7s 60.2s
Average time for Minikube (PR 9634): 60.6s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9634) |
+--------------------------------+----------+--------------------+
| * minikube v1.15.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.3s    | 35.9s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.4 | 22.7s    | 22.3s              |
| on Docker 19.03.13 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.7s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.8s               |
|   - Want kubectl v1.19.4? Try  |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| cluster and "default"          |          |                    |
| namespace by default           |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 29.9s 29.1s 29.6s
Average time for minikube: 29.5s

Times for Minikube (PR 9634): 30.4s 29.1s 30.0s
Average time for Minikube (PR 9634): 29.8s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9634) |
+--------------------------------+----------+--------------------+
| * minikube v1.15.1 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.2s     | 9.3s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.4 | 18.7s    | 18.9s              |
| on Docker 19.03.13 ...         |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.2s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.1s     | 0.0s               |
|   - Want kubectl v1.19.4? Try  |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| cluster and "default"          |          |                    |
| namespace by default           |          |                    |
+--------------------------------+----------+--------------------+

@sharifelgamal
Copy link
Collaborator

Thanks for your contribution!

@sharifelgamal sharifelgamal merged commit 6be118f into kubernetes:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@tstromberg tstromberg tstromberg left review comments

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@ilya-zuyev ilya-zuyev Awaiting requested review from ilya-zuyev

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--extra-config does not take effect on an existing cluster
9 participants
@dekkers @k8s-ci-robot @minikube-bot @TravisBuddy @priyawadhwa @minikube-pr-bot @sharifelgamal @tstromberg @medyagh