replace set-env with Env Files in GitHub Actions

[prezha]

fixes: #9541

due to the security vulnerability, GitHub Actions deprecating set-env command and replace it with Environment Files

more details are in the issue description

[k8s-ci-robot]

Hi @prezha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@prezha seems like the windows tests didn't like it

 $numFail=(echo $Env:STAT | jq '.NumberOfFail')
  $failedTests=( echo $Env:STAT | jq '.FailedTests')
  $numPass=$(echo $Env:STAT | jq '.NumberOfPass')
  $passedTests=( echo $Env:STAT | jq '.PassedTests')
  echo "*******************${numPass} Passes :) *******************"
  echo $passedTests
  echo "*******************************************************"
  echo "---------------- ${numFail} Failures :( ----------------------------"
  echo $failedTests
  echo "-------------------------------------------------------"
  If ($numFail -gt 0){ exit 2 }
  If ($numPass -eq 0){ exit 2 }
  If ($numPass -lt 33){ exit 2 }
  If ($numFail -eq 0){ exit 0 }
  shell: C:\windows\System32\WindowsPowerShell\v1.0\powershell.EXE -command ". '{0}'"
  env:
    GOPROXY: https://proxy.golang.org
    TIME_ELAPSED: time
    JOB_NAME: functional_docker_windows
    GOPOGH_RESULT: 
    STAT: 
    GOROOT: C:\Users\jenkins\actions-runner\_work\_tool\go\1.15.2\x64
******************* Passes :) *******************
*******************************************************
----------------  Failures :( ----------------------------
-------------------------------------------------------
Error: Process completed with exit code 1.

we used the set:env to pass arround the result of the test from previous step

[medyagh]

lets ensure the windows test results are passed to the End Result Step

[prezha]

@medyagh thank you for the review
i've made changes to the pr and windows test results now seem to be passed correctly to the End Result Step?

[medyagh]

looks good, do you mind pulling upstream master, to ensure get latest gh yaml

[codecov-io]

Codecov Report

Merging #9542 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9542      +/-   ##
==========================================
- Coverage   29.04%   29.04%   -0.01%     
==========================================
  Files         172      172              
  Lines       10488    10499      +11     
==========================================
+ Hits         3046     3049       +3     
- Misses       7017     7025       +8     
  Partials      425      425              

Impacted Files	Coverage Δ
cmd/minikube/cmd/root.go	43.57% <0.00%> (-3.72%)	⬇️
pkg/addons/validations.go	33.33% <0.00%> (+16.66%)	⬆️

[medyagh]

Thank you very much @prezha

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[prezha]

Thank you very much @prezha

you are most welcome @medyagh!