Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new flag --namespace for activating non default kubeconfig context #9506

Merged
merged 3 commits into from
Nov 6, 2020
Merged

new flag --namespace for activating non default kubeconfig context #9506

merged 3 commits into from
Nov 6, 2020

Commits on Nov 4, 2020

  1. add support for namespace

    @prezha
    prezha committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    3427f07 View commit details
    Browse the repository at this point in the history

  2. update --namespace flag description

    @prezha
    prezha committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    d49f417 View commit details
    Browse the repository at this point in the history

  3. revert go.mod changes 

    upgrade spf13/cobra from v1.0.0 to v1.1.1 will probably have side-effects and tests failing, ie:

'make test' suddently starting to report issues, like:

--- FAIL: TestGenerateDocs (0.02s)
    --- FAIL: TestGenerateDocs/pause (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   strings.Join({
              	... // 9 identical lines
              	"pause Kubernetes",
              	"",
            + 	"### Synopsis",
            + 	"",
            + 	"pause Kubernetes",
            + 	"",
              	"```",
              	"minikube pause [flags]",
              	... // 30 identical lines
              }, "\n")
    --- FAIL: TestGenerateDocs/unpause (0.01s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   strings.Join({
              	... // 9 identical lines
              	"unpause Kubernetes",
              	"",
            + 	"### Synopsis",
            + 	"",
            + 	"unpause Kubernetes",
            + 	"",
              	"```",
              	"minikube unpause [flags]",
              	... // 30 identical lines
              }, "\n")
    @prezha
    prezha committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    15c8fa9 View commit details
    Browse the repository at this point in the history