Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update minikube quick start in macos #9496

Closed
wants to merge 1 commit into from

Conversation

AlphaWong
Copy link

LoadBalancer issue in macOS for MiniKube

reference

#7344 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @AlphaWong!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @AlphaWong. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlphaWong
To complete the pull request process, please assign josedonizetti after the PR has been reviewed.
You can assign the PR to them by writing /assign @josedonizetti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #9496 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9496   +/-   ##
=======================================
  Coverage   29.05%   29.05%           
=======================================
  Files         171      171           
  Lines       10443    10443           
=======================================
  Hits         3034     3034           
  Misses       6987     6987           
  Partials      422      422           

Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right to me - LoadBalancer should work on macOS with all drivers.

@AlphaWong
Copy link
Author

AlphaWong commented Oct 21, 2020

This doesn't seem right to me - LoadBalancer should work on macOS with all drivers.

I get a wanting in default docker driver

Because you are using a Docker driver on darwin, the terminal needs to be open to run it.

People inside #7344 (comment) also share the same experience. It seems that it is not working in current version.

Which version u are testing with?

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to add this to docker driver docs, in MacOS.

https://minikube.sigs.k8s.io/docs/drivers/docker/#known-issues

@AlphaWong
Copy link
Author

I think you meant to add this to docker driver docs, in MacOS.

https://minikube.sigs.k8s.io/docs/drivers/docker/#known-issues

I agree that we should put it at other page but end up the quick start from https://minikube.sigs.k8s.io/docs/start/ to https://minikube.sigs.k8s.io/docs/drivers/ is not quick enough also it prefers docker driver at MacOS.

Seems more people like me as a new joiner we would like to get our local workplace up and run first. I believe some amendment or hints is required to help new user.

The real case is that I would like to setup a deployment with nginx ingress with my local Minikube for testing and I find the localBalance stuck at pending. The resolution needs to destroy the whole Minikube vm and reinstall is not that ideal in my concern.

Therefore, hints the user about the loadBalance issue or vm type or know issue can save a lot of time as it is not all the people know the history or know issue or read all the thread about Minikube. As Minikube is a good project and almost is a good learning playground for anyone I hold my opinion for adding any hints or remark on it.

Moreover, after google introduce https://github.com/GoogleContainerTools/skaffold for ensure the local and remote working environment alignment, more and more people install Minikube in their local. It is ready better to have some hints about it.

see the reference below and the screenshot.

screenshot

reference

#7344 (comment)

Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be more general, that you still need to use --vm=true if you want working network...

The docker driver is supposed to be able to limp along using minikube tunnel and such though.

@priyawadhwa
Copy link

Hey @AlphaWong are you still working on this? I agree that --vm=true would be better as it is more generic.

@priyawadhwa
Copy link

Hey @AlphaWong this PR has been quiet for a few months now, so I'm going to close it for now. Feel free to reopen whenever you have a chance to take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants