-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update minikube quick start in macos #9496
Conversation
Welcome @AlphaWong! |
Hi @AlphaWong. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AlphaWong The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #9496 +/- ##
=======================================
Coverage 29.05% 29.05%
=======================================
Files 171 171
Lines 10443 10443
=======================================
Hits 3034 3034
Misses 6987 6987
Partials 422 422 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right to me - LoadBalancer should work on macOS with all drivers.
I get a wanting in default docker driver
People inside #7344 (comment) also share the same experience. It seems that it is not working in current version. Which version u are testing with? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant to add this to docker driver docs, in MacOS.
https://minikube.sigs.k8s.io/docs/drivers/docker/#known-issues
I agree that we should put it at other page but end up the quick start from https://minikube.sigs.k8s.io/docs/start/ to https://minikube.sigs.k8s.io/docs/drivers/ is not quick enough also it prefers Seems more people like me as a new joiner we would like to get our local workplace up and run first. I believe some amendment or hints is required to help new user. The real case is that I would like to setup a deployment with nginx ingress with my local Minikube for testing and I find the Therefore, hints the user about the Moreover, after google introduce https://github.com/GoogleContainerTools/skaffold for ensure the local and remote working environment alignment, more and more people install Minikube in their local. It is ready better to have some hints about it. see the reference below and the screenshot. screenshotreference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be more general, that you still need to use --vm=true if you want working network...
The docker driver is supposed to be able to limp along using minikube tunnel
and such though.
Hey @AlphaWong are you still working on this? I agree that |
Hey @AlphaWong this PR has been quiet for a few months now, so I'm going to close it for now. Feel free to reopen whenever you have a chance to take a look! |
LoadBalancer issue in macOS for MiniKube
reference
#7344 (comment)