Upgrade go version to 1.15.2 #9280

prezha · 2020-09-20T13:48:30Z

details:

as per original issue, a total of 8 files have been changed:

minikube/.github/workflows/iso.yml (go-version: '1.14.6' -> go-version: '1.15.2') (*)
minikube/.github/workflows/kic_image.yml (go-version: '1.14.6' -> go-version: '1.15.2')
minikube/.github/workflows/master.yml (go-version: '1.14.6' -> go-version: '1.15.2')
minikube/.github/workflows/pr.yml (go-version: '1.14.6' -> go-version: '1.15.2')
minikube/hack/jenkins/common.sh (1.14.6 -> 1.15.2)
minikube/.travis.yml (1.14.6 -> 1.15.2)
minikube/go.mod (go 1.13 -> go 1.15, to match
https://github.com/kubernetes/kubernetes/blob/09b3f6dbb3224f32d28c81f330f303ac16ee2eae/go.mod#L9)
minikube/Makefile (GO_VERSION ?= 1.14.6 -> GO_VERSION ?= 1.15.2 => using k8s.gcr.io/build-image/kube-cross:v1.15.2-1 as master image)

(*)note: as per comment in the original issue and because of "# iso needs golang 1.11.3" comment at line#67 go-version at line#70 was not changed (from 1.11.13 to 1.15.2), and all other occurrences of 1.14.6 were changed to 1.15.2 in this file (minikube/.github/workflows/iso.yml) - just to make sure it is intended? // this was sorted out by @afbjorklund in pr #9331

k8s-ci-robot · 2020-09-20T13:48:37Z

Welcome @prezha!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-09-20T13:48:38Z

Hi @prezha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2020-09-20T13:57:04Z

Can one of the admins verify this patch?

prezha · 2020-09-20T14:15:05Z

/assign @tstromberg

tstromberg · 2020-09-21T15:37:32Z

/ok-to-test

prezha · 2020-09-21T19:19:55Z

are these errors known issues or something that needs to be looked at? exec format error could be related to cross-compiling config issues in the pipeline...

please note: all local tests were passing successfully and i've also tested with both kvm2 and default (docker) driver locally before submitting PR (on linux machine) - happy to provide more details or look at it if needed

minikube-pr-bot · 2020-09-21T19:37:11Z

kvm2 Driver
Times for minikube: 68.2s 63.1s 64.5s
Average time for minikube: 65.3s

Times for Minikube (PR 9280): 61.8s 63.3s 67.1s
Average time for Minikube (PR 9280): 64.1s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9280) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     |                    |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Downloading driver           | 1.9s     |                    |
| docker-machine-driver-kvm2:    |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 37.8s    | 37.2s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 24.2s    | 24.4s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.7s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.8s     | 0.6s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 31.6s 31.7s 30.7s
Average time for minikube: 31.4s

Times for Minikube (PR 9280): 30.0s 30.5s 31.6s
Average time for Minikube (PR 9280): 30.7s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9280) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     |                    |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.2s     | 9.1s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 20.3s    | 20.1s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.3s     | 1.0s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

medyagh · 2020-09-21T20:15:30Z

/retest this please

k8s-ci-robot · 2020-09-21T20:15:32Z

@medyagh: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

/test pull-minikube-platform-tests

In response to this:

/retest this please

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

medyagh · 2020-09-21T20:15:56Z

/retest-this-please

prezha · 2020-09-24T22:33:52Z

@medyagh do we need anything additionally regarding this pr/issue?
please let me know
thanks

sharifelgamal · 2020-09-25T17:21:36Z

/ok-to-test

sharifelgamal · 2020-09-25T17:22:38Z

This code looks fine to me, but there seems to be an abnormal number of failing tests, I'm going to rerun them to see if there's an actual issue or if it's just a flake.

prezha · 2020-09-25T17:24:59Z

thank you @sharifelgamal for your review and rerunning the tests

afbjorklund · 2020-09-27T07:51:04Z

(*)note: as per comment in the original issue and because of "# iso needs golang 1.11.3" comment at line#67 go-version at line#70 was not changed (from 1.11.13 to 1.15.2), and all other occurrences of 1.14.6 were changed to 1.15.2 in this file (minikube/.github/workflows/iso.yml) - just to make sure it is intended?

The comment about the go version used in Buildroot was more internal, it doesn't affect this PR... You don't have to set the go version at all for the ISO build, although it doesn't really "hurt" anything. The build does a cross-compile of everything, since we are using the go compiler from the system. This works fine for more "traditional" programs, but it is not progressive enough for Kubernetes. Might have to look at providing our own compiler (somehow), just for building some packages like podman/cri-o.

https://github.com/buildroot/buildroot/blob/2019.02.x/package/go/go.mk#L7

GO_VERSION = 1.11.13

https://github.com/buildroot/buildroot/blob/2020.02.x/package/go/go.mk#L7

GO_VERSION = 1.13.15

Anyway, that is being handled under #7904 as part of related issue #8388

k8s-ci-robot · 2020-10-04T00:59:39Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prezha
To complete the pull request process, please assign tstromberg after the PR has been reviewed.
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

prezha · 2020-10-04T01:33:46Z

@afbjorklund thank you for clearing that out

i have also rebased the original pr to the current master head to pick up all the changes that happened since it was created, as some tests that were failing before seems to be unrelated to this pr (changing golang version), ie, for Docker_Linux:

=== RUN   TestFunctional/serial/MinikubeKubectlCmdDirectly
functional_test.go:332: (dbg) Run:  out/kubectl get pods
functional_test.go:332: (dbg) Non-zero exit: out/kubectl get pods: exit status 85 (58.2492ms)
-- stdout --
	* There is no local cluster named "minikube"
	  - To fix this, run: "minikube start"
-- /stdout --
functional_test.go:334: failed to run kubectl directl. args "out/kubectl get pods": exit status 85

can we please re-test?

prezha · 2020-10-04T01:33:51Z

/assign @tstromberg

afbjorklund · 2020-10-10T07:38:26Z

@medyagh @tstromberg:
Was there anything left to do here, or did you want to wait with go1.15 (#9264) until v1.15.0 and Kubernetes 1.20 ?

codecov-io · 2020-10-14T20:24:27Z

Codecov Report

Merging #9280 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9280   +/-   ##
=======================================
  Coverage   29.05%   29.05%           
=======================================
  Files         171      171           
  Lines       10444    10444           
=======================================
  Hits         3034     3034           
  Misses       6988     6988           
  Partials      422      422

tstromberg · 2020-10-21T16:30:47Z

LGTM. Thank you!

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 20, 2020

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2020

k8s-ci-robot requested review from RA489 and sharifelgamal September 20, 2020 13:48

k8s-ci-robot assigned tstromberg Sep 20, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 21, 2020

kubernetes deleted a comment from minikube-pr-bot Sep 21, 2020

afbjorklund mentioned this pull request Sep 27, 2020

The ISO build doesn't need Go installed on host #9331

Merged

prezha force-pushed the go-v1.15.2 branch from 425e641 to 22f0d25 Compare October 4, 2020 00:59

prezha mentioned this pull request Oct 11, 2020

automate pushing kicbase image from snapshot to stable after release #9420

Closed

Upgrade go version to 1.15.2

570f4f3

prezha force-pushed the go-v1.15.2 branch from 22f0d25 to 570f4f3 Compare October 14, 2020 20:01

tstromberg merged commit f931b89 into kubernetes:master Oct 21, 2020

prezha mentioned this pull request Oct 22, 2020

hack/update: golang version #9531

Merged

prezha mentioned this pull request Feb 19, 2021

REQUEST: New membership for prezha kubernetes/org#2514

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade go version to 1.15.2 #9280

Upgrade go version to 1.15.2 #9280

prezha commented Sep 20, 2020 •

edited

Loading

k8s-ci-robot commented Sep 20, 2020

k8s-ci-robot commented Sep 20, 2020

minikube-bot commented Sep 20, 2020

prezha commented Sep 20, 2020

tstromberg commented Sep 21, 2020

prezha commented Sep 21, 2020 •

edited

Loading

minikube-pr-bot commented Sep 21, 2020

medyagh commented Sep 21, 2020

k8s-ci-robot commented Sep 21, 2020

medyagh commented Sep 21, 2020

prezha commented Sep 24, 2020

sharifelgamal commented Sep 25, 2020

sharifelgamal commented Sep 25, 2020

prezha commented Sep 25, 2020 •

edited

Loading

afbjorklund commented Sep 27, 2020

k8s-ci-robot commented Oct 4, 2020

prezha commented Oct 4, 2020 •

edited

Loading

prezha commented Oct 4, 2020

afbjorklund commented Oct 10, 2020

codecov-io commented Oct 14, 2020

tstromberg commented Oct 21, 2020

Upgrade go version to 1.15.2 #9280

Upgrade go version to 1.15.2 #9280

Conversation

prezha commented Sep 20, 2020 • edited Loading

details:

k8s-ci-robot commented Sep 20, 2020

k8s-ci-robot commented Sep 20, 2020

minikube-bot commented Sep 20, 2020

prezha commented Sep 20, 2020

tstromberg commented Sep 21, 2020

prezha commented Sep 21, 2020 • edited Loading

minikube-pr-bot commented Sep 21, 2020

medyagh commented Sep 21, 2020

k8s-ci-robot commented Sep 21, 2020

medyagh commented Sep 21, 2020

prezha commented Sep 24, 2020

sharifelgamal commented Sep 25, 2020

sharifelgamal commented Sep 25, 2020

prezha commented Sep 25, 2020 • edited Loading

afbjorklund commented Sep 27, 2020

k8s-ci-robot commented Oct 4, 2020

prezha commented Oct 4, 2020 • edited Loading

prezha commented Oct 4, 2020

afbjorklund commented Oct 10, 2020

codecov-io commented Oct 14, 2020

Codecov Report

tstromberg commented Oct 21, 2020

prezha commented Sep 20, 2020 •

edited

Loading

prezha commented Sep 21, 2020 •

edited

Loading

prezha commented Sep 25, 2020 •

edited

Loading

prezha commented Oct 4, 2020 •

edited

Loading