-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair kubecontext before checking cluster health #9143
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 Driver Times for Minikube (PR 9143): 66.1s 64.6s 65.8s Averages Time Per Log
docker Driver Times for Minikube (PR 9143): 28.3s 28.6s 29.7s Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This fixes this ugly error noticed by @MarlonGamez and myself:
🤦 Unable to restart cluster, will reset it: getting k8s client: client config: client config: context "minikube" does not exist
With this PR, we no longer unnecessarily call
kubeadm reset
if the only thing wrong with the cluster is a missing kube config entry. This reduces restart time from 73.83s to 5.4s in this particular scenario:minikube start && sleep 30 && rm $HOME/.kube/config && minikube start