Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --memory flag parsing in minikube start #9033

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Fix --memory flag parsing in minikube start #9033

merged 1 commit into from
Aug 20, 2020

Commits on Aug 20, 2020

  1. Fix --memory flag parsing in minikube start 

    Due to the way Go handles variable scope, `mem` was being
redeclared inside the conditional. Outside, we were stuck with the value
provided by `suggestMemoryAllocation`, therefore ignoring the value
passed through the `--memory` flag.
    @vixus0
    vixus0 committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    6e8f596 View commit details
    Browse the repository at this point in the history