-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: prioritize /etc/hosts over dns #9029
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: e7dd98c0-e1ae-11ea-81c3-ef1e647c3fbd |
I can confirm that this change is visible in child containers, including kubelet and kube-apiserver:
|
Codecov Report
@@ Coverage Diff @@
## master #9029 +/- ##
=======================================
Coverage 31.66% 31.66%
=======================================
Files 166 166
Lines 11326 11326
=======================================
Hits 3586 3586
Misses 7309 7309
Partials 431 431 |
Some DNS servers issue fraudulent A/AAA responses for hosts which return NXDOMAIN:
https://www.verizon.com/support/residential/internet/home-network/settings/opt-out-of-dns-assist
This unfortunately breaks the ability for minikube nodes to discover the location of the apiserver. This change modifies the system to prioritize /etc/hosts first, and is propagated out to each pod.
Fixes #9051