update crio to 1.18.3 and kicbase to ubuntu 20.04 #8895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Travis tests have failedHey @sharifelgamal, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: bc0d6eb0-d2b2-11ea-9c70-53a116b43db5 |
tstromberg
suggested changes
Jul 30, 2020
| @@ -202,6 +202,16 @@ func runStart(cmd *cobra.Command, args []string) { | |||
| } | |||
| } | |||
|
|
|||
| if existing != nil && existing.KubernetesConfig.ContainerRuntime == "crio" && driver.IsKIC(existing.Driver) { | |||
There was a problem hiding this comment.
I'm not following this -- doesn't this run only if the previous provisionWithDriver error == nil?
There was a problem hiding this comment.
correct, provision isn't what fails for crio, it's starting k8s that fails. what I found works is if we just stop and start again here, everything works as expected.
I'm basically emulating restarting and failing, then calling minikube stop then calling minikube start again, except I'm skipping the 6 minutes we need to wait for apiserver to not come back in the startWithDriver portion of the code.
again, I have no idea why, but empirically it works and it makes the tests pass.
medyagh
requested changes
Jul 31, 2020
Travis tests have failedHey @sharifelgamal, 1st Buildmake testTravisBuddy Request Identifier: 72b0be20-d2e9-11ea-8b20-77bf1110b312 |
medyagh
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently versions of crio above 1.17.3 (which magically vanished into the ether) fails on a node restart, so I've had an admittedly horrible hack to fix it while we discover the root cause.