Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kic entrypoint: retryable update-alternatives, move earlier into execution #8864

Merged
merged 3 commits into from
Jul 28, 2020
Merged

kic entrypoint: retryable update-alternatives, move earlier into execution #8864

merged 3 commits into from
Jul 28, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jul 28, 2020 •
edited
Loading

copying the need-rebase PR form @tstromberg #8826

Makes #8814 easier to debug - and may actually just resolve it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@medyagh medyagh changed the title improve update alternative kic entrypoint: retryable update-alternatives, move earlier into execution Jul 28, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2020
@medyagh
Copy link
Member Author

medyagh commented Jul 28, 2020

Test failures are only Crio
and the other verifyKubernetesImages" is not related to this PR

---------------- 8 Failures :( ----------------------------
[
"TestStartStop/group/embed-certs/serial/VerifyKubernetesImages",
"TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages",
"TestStartStop/group/containerd/serial/VerifyKubernetesImages",
"TestStartStop/group/crio/serial/SecondStart",
"TestNetworkPlugins/group/cilium/DNS",
"TestStartStop/group/crio/serial/UserAppExistsAfterStop",
"TestStartStop/group/crio/serial/AddonExistsAfterStop",
"TestStartStop/group/crio/serial/Pause"
]

@medyagh medyagh merged commit f7e6805 into kubernetes:master Jul 28, 2020
@medyagh medyagh mentioned this pull request Jul 30, 2020
Closed
@fmotrifork fmotrifork mentioned this pull request Aug 6, 2020
Merged
@medyagh medyagh deleted the kb_update_alter branch March 2, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@medyagh @k8s-ci-robot @tstromberg