Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang version #8781

Merged
merged 1 commit into from
Jul 20, 2020
Merged

update golang version #8781

merged 1 commit into from
Jul 20, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jul 20, 2020

go 1.14.6 fixed the issue which "multiple test were talking over each other" golang/go#39308

fixes #8349

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2020
@medyagh
Copy link
Member Author

medyagh commented Jul 20, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 20, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [63.870594625 62.148807594 63.781609024999995]
Average time for minikube: 63.267003748

Times for Minikube (PR 8781): [62.747870231 63.469869662 65.14770395400001]
Average time for Minikube (PR 8781): 63.78848128233333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8781) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.057052 |           0.060793 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018882 |           0.023338 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004480 |           0.017743 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.027079 |          40.802359 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 20.477547 |          20.690597 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.237322 |           1.640176 |
| components...                  |           |                    |
| * Enabled addons:              |  0.356387 |           0.478870 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.085140 |           0.069769 |
| configured to use "minikube"   |           |                    |
|                                |  0.003115 |           0.004836 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.412387708999997 27.383450589 26.633988369]
Average time for minikube: 27.143275555666662

Times for Minikube (PR 8781): [25.745537775 25.324334727000004 26.474664659000005]
Average time for Minikube (PR 8781): 25.84817905366667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8781) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.077421 |           0.083681 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.002607 |           0.002747 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.060429 |           0.057205 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.728094 |           8.391539 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 17.314771 |          16.310532 |
| on Docker 19.03.2 ...          |           |                    |
| * Verifying Kubernetes         |  0.836912 |           0.884635 |
| components...                  |           |                    |
| * Enabled addons:              |  0.059464 |           0.050701 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.059510 |           0.063769 |
| configured to use "minikube"   |           |                    |
|                                |  0.004068 |           0.003370 |
+--------------------------------+-----------+--------------------+

@medyagh medyagh merged commit 2183c90 into kubernetes:master Jul 20, 2020
@medyagh medyagh deleted the update_go_ver branch March 2, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel test output is sometimes assigned to the wrong test in JSON
4 participants