Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Buildroot version from 2020.02 to 2019.02 #8649

Merged
merged 2 commits into from
Jul 5, 2020

Conversation

afbjorklund
Copy link
Collaborator

Since there were test failures when running the new ISO

Upgrade the minor Buildroot version instead, to 2019.02.11

There might be some configuration changes to revert as well

Trying to keep the new versions of the added packages though

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 5, 2020
@afbjorklund afbjorklund requested a review from medyagh July 5, 2020 20:38
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2020
@medyagh medyagh merged commit 4623a76 into kubernetes:master Jul 5, 2020
@medyagh medyagh changed the title WIP: Revert Buildroot version from 2020.02 to 2019.02 Revert Buildroot version from 2020.02 to 2019.02 Jul 5, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2020
@alban
Copy link
Contributor

alban commented Jul 12, 2020

@afbjorklund Do you have a link to the test failures?
I am interested in the new kernel for #8556 (comment) and I wonder which failures should I expect if I run Minikube without this revert.

@afbjorklund
Copy link
Collaborator Author

Look for the PRs with “new ISO”

It worked OK for me, but there were some regression tests that timed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants