docker driver on linux: warn if overlay module is not enabled #8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
afbjorklund
requested changes
Jun 23, 2020
afbjorklund
approved these changes
Jun 24, 2020
| @@ -616,6 +616,13 @@ func validateDriver(ds registry.DriverState, existing *config.ClusterConfig) { | |||
| st := ds.State | |||
| glog.Infof("status for %s: %+v", name, st) | |||
|
|
|||
| if st.NeedsImprovement { // warn but don't exit | |||
| out.ErrLn("") | |||
| out.WarningT("'{{.driver}}' driver reported a issue that could affect the performance.", out.V{"driver": name}) | |||
There was a problem hiding this comment.
{{.driver}} driver reported an issue that could affect performance
medyagh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we install the docker inside minikube with overlayfs storage driver.
and it is not currently on our roadmap to support others, and and if you are on linux and your linux kernel does not have overlayfs then it will have significant slow performances
after this PR:
(ignore that it is running on darwin I fliped the If statement to make error in darwin)
this should only add warnning for linux, since docker-machine comes with overlayfs on mac and windows