Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl: fix logging the kubectl path #8521

Merged
merged 1 commit into from
Jun 22, 2020
Merged

kubectl: fix logging the kubectl path #8521

merged 1 commit into from
Jun 22, 2020

Conversation

afbjorklund
Copy link
Collaborator

After introducing the exec.Cmd parameter previously

Just logging empty string:

Running [version]

Supposed to be the path.

@afbjorklund
The logging of the kubectl path was broken
fe66873 
After introducing the exec.Cmd parameter previously
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 20, 2020
@afbjorklund afbjorklund mentioned this pull request Jun 20, 2020
Merged
@TravisBuddy
Copy link

Travis tests have failed

Hey @afbjorklund,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test 
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.0-beta.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.11.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="9b5c84cabff00655ea79332a19e4073a2456091d"" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: extracting github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: extracting github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
go: extracting github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
go: finding github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: finding github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: finding github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading k8s.io/apimachinery v0.17.3
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading k8s.io/api v0.17.3
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: extracting golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/pkg/errors v0.9.1
go: extracting github.com/pkg/errors v0.9.1
go: downloading github.com/spf13/cobra v1.0.0
go: extracting k8s.io/apimachinery v0.17.3
go: extracting golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: extracting github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: extracting github.com/spf13/cobra v1.0.0
go: downloading github.com/otiai10/copy v1.0.2
go: extracting k8s.io/client-go v0.17.3
go: extracting github.com/otiai10/copy v1.0.2
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/docker/go-units v0.4.0
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: extracting github.com/docker/go-units v0.4.0
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: extracting github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: extracting github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: extracting k8s.io/klog v1.0.0
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: extracting github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: extracting github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: extracting github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading golang.org/x/text v0.3.2
go: extracting k8s.io/api v0.17.3
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/google/uuid v1.1.1
go: extracting github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: extracting golang.org/x/sys v0.0.0-20200523222454-059865788121
go: extracting github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: extracting github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading k8s.io/kubernetes v1.17.3
go: extracting github.com/google/uuid v1.1.1
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: extracting github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: extracting github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: extracting github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: extracting github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: extracting github.com/gogo/protobuf v1.3.1
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: extracting github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: extracting github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/hashicorp/go-version v1.2.0
go: extracting golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/google/gofuzz v1.0.0
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: extracting golang.org/x/text v0.3.2
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: extracting github.com/google/gofuzz v1.0.0
go: extracting github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: extracting github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/googleapis/gnostic v0.3.0
go: extracting github.com/shirou/gopsutil v2.18.12+incompatible
go: extracting k8s.io/kubernetes v1.17.3
go: extracting github.com/hashicorp/go-version v1.2.0
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: extracting github.com/libvirt/libvirt-go v3.4.0+incompatible
go: extracting github.com/aws/aws-sdk-go v1.31.6
go: extracting github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: extracting github.com/hashicorp/go-safetemp v1.0.0
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: extracting github.com/googleapis/gnostic v0.3.0
go: extracting github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/mattn/go-isatty v0.0.12
go: extracting google.golang.org/api v0.25.0
go: extracting github.com/mattn/go-isatty v0.0.12
go: extracting github.com/hashicorp/go-cleanhttp v0.5.1
go: extracting sigs.k8s.io/yaml v1.1.0
go: downloading github.com/ulikunitz/xz v0.5.7
go: extracting github.com/cheggaaa/pb v1.0.27
go: downloading github.com/json-iterator/go v1.1.8
go: extracting github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: extracting github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/davecgh/go-spew v1.1.1
go: extracting gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: extracting github.com/russross/blackfriday/v2 v2.0.1
go: extracting github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/spf13/viper v1.7.0
go: extracting github.com/spf13/viper v1.7.0
go: extracting github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: extracting k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: extracting github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: extracting github.com/davecgh/go-spew v1.1.1
go: extracting github.com/ulikunitz/xz v0.5.7
go: extracting k8s.io/kubectl v0.17.3
go: extracting github.com/json-iterator/go v1.1.8
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading google.golang.org/grpc v1.29.1
go: downloading k8s.io/kube-proxy v0.17.3
go: extracting golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: extracting github.com/mattn/go-runewidth v0.0.7
go: extracting gopkg.in/ini.v1 v1.56.0
go: extracting github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: extracting github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/spf13/afero v1.2.2
go: extracting github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: extracting github.com/mattn/go-colorable v0.1.6
go: extracting github.com/imdario/mergo v0.3.9
go: downloading github.com/blang/semver v3.5.0+incompatible
go: extracting google.golang.org/grpc v1.29.1
go: downloading github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: downloading github.com/hashicorp/hcl v1.0.0
go: extracting github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/VividCortex/ewma v1.1.1
go: extracting k8s.io/kube-proxy v0.17.3
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: extracting k8s.io/cluster-bootstrap v0.17.3
go: extracting github.com/VividCortex/ewma v1.1.1
go: extracting github.com/fatih/color v1.9.0
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: extracting github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: extracting github.com/golang/protobuf v1.4.2
go: downloading github.com/magiconair/properties v1.8.1
go: extracting github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: extracting github.com/fsnotify/fsnotify v1.4.9
go: extracting github.com/spf13/afero v1.2.2
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: extracting github.com/blang/semver v3.5.0+incompatible
go: extracting github.com/hashicorp/hcl v1.0.0
go: extracting github.com/mitchellh/mapstructure v1.3.1
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/google/go-cmp v0.4.1
go: downloading k8s.io/kubelet v0.17.3
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: extracting github.com/magiconair/properties v1.8.1
go: extracting github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/sirupsen/logrus v1.6.0
go: extracting github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: extracting k8s.io/kubelet v0.17.3
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/docker/go-connections v0.4.0
go: extracting github.com/pelletier/go-toml v1.8.0
go: extracting k8s.io/component-base v0.17.3
go: extracting github.com/google/go-cmp v0.4.1
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: extracting github.com/docker/go-connections v0.4.0
go: extracting github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: extracting golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: extracting gopkg.in/inf.v0 v0.9.1
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: extracting github.com/sirupsen/logrus v1.6.0
go: extracting github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: extracting github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: extracting github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: extracting github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: extracting google.golang.org/protobuf v1.24.0
go: extracting sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: extracting github.com/opencontainers/image-spec v1.0.1
go: extracting cloud.google.com/go v0.57.0
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/prometheus/client_golang v1.1.0
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: extracting github.com/docker/distribution v2.7.1+incompatible
go: extracting github.com/spf13/cast v1.3.1
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: extracting github.com/prometheus/client_golang v1.1.0
go: extracting github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: extracting github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/miekg/dns v1.1.4
go: downloading github.com/subosito/gotenv v1.2.0
go: extracting cloud.google.com/go/storage v1.8.0
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: extracting github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/spf13/pflag v1.0.5
go: extracting github.com/subosito/gotenv v1.2.0
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: downloading github.com/prometheus/common v0.6.0
go: extracting github.com/miekg/dns v1.1.4
go: extracting github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading go.opencensus.io v0.22.3
go: extracting github.com/spf13/pflag v1.0.5
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: extracting github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/prometheus/procfs v0.0.5
go: extracting github.com/prometheus/common v0.6.0
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: extracting go.opencensus.io v0.22.3
go: extracting github.com/prometheus/procfs v0.0.5
go: downloading github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: downloading github.com/beorn7/perks v1.0.1
go: extracting github.com/googleapis/gax-go v2.0.2+incompatible
go: extracting github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: extracting github.com/jmespath/go-jmespath v0.3.0
go: extracting github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: extracting github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: extracting github.com/beorn7/perks v1.0.1
go: extracting github.com/matttproud/golang_protobuf_extensions v1.0.1
go: extracting k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: extracting google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: finding github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: finding github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: finding github.com/pkg/errors v0.9.1
go: finding github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: finding github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: finding github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: finding github.com/docker/go-units v0.4.0
go: finding github.com/spf13/cobra v1.0.0
go: finding github.com/olekukonko/tablewriter v0.0.4
go: finding github.com/blang/semver v3.5.0+incompatible
go: finding k8s.io/client-go v0.17.3
go: finding github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: finding github.com/libvirt/libvirt-go v3.4.0+incompatible
go: finding github.com/spf13/viper v1.7.0
go: finding golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: finding github.com/mattn/go-runewidth v0.0.7
go: finding github.com/imdario/mergo v0.3.9
go: finding k8s.io/api v0.17.3
go: finding github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: finding github.com/spf13/pflag v1.0.5
go: finding k8s.io/apimachinery v0.17.3
go: finding golang.org/x/sys v0.0.0-20200523222454-059865788121
go: finding github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: finding github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: finding github.com/mattn/go-isatty v0.0.12
go: finding github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: finding github.com/gogo/protobuf v1.3.1
go: finding github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: finding github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: finding github.com/google/uuid v1.1.1
go: finding github.com/fsnotify/fsnotify v1.4.9
go: finding github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: finding github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: finding github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: finding github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: finding github.com/hashicorp/hcl v1.0.0
go: finding github.com/shirou/gopsutil v2.18.12+incompatible
go: finding github.com/magiconair/properties v1.8.1
go: finding github.com/google/gofuzz v1.0.0
go: finding github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: finding cloud.google.com/go/storage v1.8.0
go: finding github.com/mitchellh/mapstructure v1.3.1
go: finding sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: finding k8s.io/klog v1.0.0
go: finding golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: finding github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: finding github.com/pelletier/go-toml v1.8.0
go: finding github.com/cenkalti/backoff v2.2.1+incompatible
go: finding github.com/docker/docker-credential-helpers v0.6.3
go: finding github.com/golang/protobuf v1.4.2
go: finding github.com/otiai10/copy v1.0.2
go: finding gopkg.in/inf.v0 v0.9.1
go: finding github.com/cpuguy83/go-md2man/v2 v2.0.0
go: finding golang.org/x/text v0.3.2
go: finding github.com/spf13/afero v1.2.2
go: finding cloud.google.com/go v0.57.0
go: finding github.com/docker/distribution v2.7.1+incompatible
go: finding github.com/googleapis/gnostic v0.3.0
go: finding github.com/spf13/cast v1.3.1
go: finding github.com/prometheus/client_golang v1.1.0
go: finding golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: finding github.com/russross/blackfriday/v2 v2.0.1
go: finding github.com/spf13/jwalterweatherman v1.1.0
go: finding gopkg.in/yaml.v2 v2.3.0
go: finding k8s.io/kubernetes v1.17.3
go: finding github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: finding golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: finding github.com/googleapis/gax-go/v2 v2.0.5
go: finding github.com/cheggaaa/pb/v3 v3.0.1
go: finding github.com/subosito/gotenv v1.2.0
go: finding google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: finding github.com/opencontainers/go-digest v1.0.0-rc1
go: finding github.com/shurcooL/sanitized_anchor_name v1.0.0
go: finding gopkg.in/ini.v1 v1.56.0
go: finding google.golang.org/protobuf v1.24.0
go: finding google.golang.org/api v0.25.0
go: finding google.golang.org/grpc v1.29.1
go: finding go.opencensus.io v0.22.3
go: finding github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: finding k8s.io/kubectl v0.17.3
go: finding k8s.io/component-base v0.17.3
go: finding github.com/VividCortex/ewma v1.1.1
go: finding github.com/json-iterator/go v1.1.8
go: finding github.com/beorn7/perks v1.0.1
go: finding github.com/docker/go-connections v0.4.0
go: finding github.com/modern-go/reflect2 v1.0.1
go: finding github.com/fatih/color v1.9.0
go: finding github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: finding github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: finding github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: finding github.com/mattn/go-colorable v0.1.6
go: finding github.com/prometheus/common v0.6.0
go: finding github.com/opencontainers/image-spec v1.0.1
go: finding github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: finding github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: finding github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: finding golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: finding github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: finding github.com/davecgh/go-spew v1.1.1
go: finding github.com/prometheus/procfs v0.0.5
go: finding github.com/sirupsen/logrus v1.6.0
go: finding k8s.io/cluster-bootstrap v0.17.3
go: finding github.com/matttproud/golang_protobuf_extensions v1.0.1
go: finding sigs.k8s.io/yaml v1.1.0
go: finding k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: finding github.com/mitchellh/go-wordwrap v1.0.0
go: finding github.com/aws/aws-sdk-go v1.31.6
go: finding k8s.io/kube-proxy v0.17.3
go: finding k8s.io/kubelet v0.17.3
go: finding github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: finding github.com/miekg/dns v1.1.4
go: finding github.com/hashicorp/go-cleanhttp v0.5.1
go: finding github.com/hashicorp/go-safetemp v1.0.0
go: finding github.com/hashicorp/go-version v1.2.0
go: finding github.com/hashicorp/golang-lru v0.5.3
go: finding github.com/mitchellh/go-homedir v1.1.0
go: finding github.com/mitchellh/go-testing-interface v1.0.0
go: finding github.com/ulikunitz/xz v0.5.7
go: finding github.com/google/go-cmp v0.4.1
go: finding k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: finding github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: finding github.com/jmespath/go-jmespath v0.3.0
go: finding github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: extracting github.com/evanphx/json-patch v4.5.0+incompatible
go: extracting github.com/pmezard/go-difflib v1.0.0
go: extracting golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: finding github.com/pmezard/go-difflib v1.0.0
go: finding golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: finding github.com/evanphx/json-patch v4.5.0+incompatible
ok  	k8s.io/minikube/cmd/minikube/cmd	3.943s	coverage: 20.4% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.150s	coverage: 21.5% of statements
E0620 12:37:51.056991   12006 out.go:102] [unset errFile]: * 
E0620 12:37:51.057202   12006 out.go:102] [unset errFile]: X Error getting primary control plane: remove /tmp/profile775859790/.minikube/profiles/config.json: no such file or directory
E0620 12:37:51.057236   12006 out.go:102] [unset errFile]: * 
E0620 12:37:51.057258   12006 out.go:102] [unset errFile]: * minikube is exiting due to an error. If the above message is not useful, open an issue:
E0620 12:37:51.057291   12006 out.go:102] [unset errFile]:   - https://github.com/kubernetes/minikube/issues/new/choose
FAIL	k8s.io/minikube/pkg/addons	0.057s
ok  	k8s.io/minikube/pkg/drivers	0.025s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.006s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.022s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.765s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.077s	coverage: 63.2% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.019s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.009s	coverage: 88.9% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.047s	coverage: 16.8% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.015s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.139s	coverage: 67.3% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.056s	coverage: 40.6% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.016s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.033s	coverage: 37.1% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.008s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.034s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.026s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.009s	coverage: 51.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.051s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.473s	coverage: 37.8% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.011s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.044s	coverage: 67.4% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.216s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.023s	coverage: 91.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.007s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.006s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.071s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.019s	coverage: 96.9% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.018s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.026s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.005s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.614s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.865s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.009s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.006s	coverage: 0.0% of statements
FAIL
Makefile:273: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: 164af670-b2f3-11ea-894e-97d5968798bd

@medyagh
Copy link
Member

medyagh commented Jun 21, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 21, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [65.90449049399999 58.630803962 65.053506441]
Average time for minikube: 63.19626696566666

Times for Minikube (PR 8521): [69.22732308200001 65.57392998899999 64.576843842]
Average time for Minikube (PR 8521): 66.45936563766668

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8521) |
+--------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian   |  0.063010 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.021052 |           0.020289 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.014599 |           0.003346 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.971211 |          41.589308 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.394683 |          22.720619 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.257162 |           1.554198 |
| components...                  |           |                    |
| * Enabled addons:              |  0.377469 |           0.437541 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.092175 |           0.070361 |
| configured to use "minikube"   |           |                    |
|                                |  0.004906 |           0.004172 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.110794863 27.307116647 27.078300967999997]
Average time for minikube: 26.832070826000002

Times for Minikube (PR 8521): [27.800628382999996 26.207758120999998 25.408711030000003]
Average time for Minikube (PR 8521): 26.472365844666665

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8521) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian           |  0.075613 |                    |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002557 |           0.002499 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.060759 |           0.059044 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.937172 |           7.755500 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.3         |  0.124080 |           0.123406 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.558824 |          17.515221 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.787076 |           0.774992 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.210603 |           0.099626 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.070441 |           0.061211 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004947 |           0.005447 |
+----------------------------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Jun 22, 2020

/retest-this-please

@medyagh medyagh merged commit 3d09d8e into kubernetes:master Jun 22, 2020
@medyagh medyagh changed the title The logging of the kubectl path was broken fix logging the kubectl path Jun 22, 2020
@medyagh medyagh changed the title fix logging the kubectl path kubectl: fix logging the kubectl path Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afbjorklund @k8s-ci-robot @TravisBuddy @medyagh @minikube-pr-bot