Add addon : pod-security-policy

[colvin]

Create a new addon, podsecuritypolicies that applies the
PodSecurityPolicy and related RBAC configuration from the
https://minikube.sigs.k8s.io/docs/tutorials/using_psp/ tutorial.
Apparently, recent work on the addons system has invalidated the
procedure shown in that tutorial, as the configuration is no longer
automatically applied. The last known working version is 1.6.2.

This allows clusters started with
--extra-configs=apiserver.enable-admission-plugins=PodSecurityPolicy
to succeed, so long as they also include --addons=podsecuritypolicies.

Fixes #7314
Fixes #6686

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @colvin!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @colvin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: colvin
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[codecov-commenter]

Codecov Report

Merging #8454 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8454   +/-   ##
=======================================
  Coverage   34.05%   34.05%           
=======================================
  Files         153      153           
  Lines        9840     9840           
=======================================
  Hits         3351     3351           
  Misses       6086     6086           
  Partials      403      403           

[colvin]

I signed it

[colvin]

This time I actually did sign it

[colvin]

/assign @sharifelgamal

[colvin]

/test ?

[k8s-ci-robot]

@colvin: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[medyagh]

@colvin thank you for making contribution to minikube, could you please justify an example of using this addon, and why this needs to be an addon (maybe with an end to end scenario )

and also the name chosen for this addon is hard to read, could you please choose a better name that is better typed and read

for example of minikube addons
run: minikbue addons list

[colvin]

@medyagh
The PodSecurityPolicy admission controller must be specified when the apiserver starts (--enable-admission-plugins=PodSecurityPolicy), however in doing so the core services are prevented from being provisioned with a "no providers available to validate pod request" error. A policy allowing the creation of the core services must also be applied when the cluster starts.

Recent changes to the addons system prevents arbitrary user-supplied files from being applied to the cluster when provisioned, instead only applying those that are specified as an addon. Therefore, unless I'm incorrect, the only way to apply the policy that allows the cluster to start with the PodSecurityPolicy admission plugin is to implement an addon.

The name of the addon directly reflects the name of the API (policy/v1beta1/podsecuritypolicy) as well as the policy resource and admission controller (PodSecurityPolicy). That said, I'm open to suggestions on a better name.

[medyagh]

@medyagh
The PodSecurityPolicy admission controller must be specified when the apiserver starts (--enable-admission-plugins=PodSecurityPolicy), however in doing so the core services are prevented from being provisioned with a "no providers available to validate pod request" error. A policy allowing the creation of the core services must also be applied when the cluster starts.

Recent changes to the addons system prevents arbitrary user-supplied files from being applied to the cluster when provisioned, instead only applying those that are specified as an addon. Therefore, unless I'm incorrect, the only way to apply the policy that allows the cluster to start with the PodSecurityPolicy admission plugin is to implement an addon.

The name of the addon directly reflects the name of the API (policy/v1beta1/podsecuritypolicy) as well as the policy resource and admission controller (PodSecurityPolicy). That said, I'm open to suggestions on a better name.

how about a name format that could be read and typed better maybe pod_security_policy

could you please an example for this addon maybe as docs in the site or as a tutorial in the site?
https://minikube.sigs.k8s.io/docs/tutorials/

[colvin]

Thanks for the suggestion @medyagh. I've renamed the addon to pod-security-policy.

I'll take a look at updating the tutorial here. It has been out of date and not working since version 1.6.2, which is what inspired me to do this work.

[Chili-Man]

@medyagh hey can we get some more movement on this , it seems that @colvin has addressed your comments. It would be great if we can get this fix merged in sooner so that the documentation isn't misleading

[medyagh]

@colvin @Chili-Man thanks for your patience and sorry for the delay in this PR review.

it looks good it will be included in the next release v1.1.2.0

thank you for this contribution and I hope you contribute again

[Chili-Man]

thanks @medyagh , we appreciate it!

[colvin]

Thanks @medyagh, @Chili-Man