Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set leader-elect=false for scheduler and controller manager #8431

Merged
merged 5 commits into from
Jun 10, 2020
Merged

Set leader-elect=false for scheduler and controller manager #8431

merged 5 commits into from
Jun 10, 2020

Conversation

priyawadhwa
Copy link

Both the scheduler and controller manager constantly ping the apiserver to ensure leader election. From the docs:

Enable this when running replicated components for high availability.

which we don't really need in minikube. This should reduce overall overhead by ~12% according to Thomas's calculations, and around 14% according to mine. Let's play it safe and say 12%, which gets us halfway to finishing #5682

Set leader-elect=false for scheduler and controller manager
5e1966e 
both the scheduler and controller manager constantly ping the apiserver to ensure leader election. From the docs:

```
Enable this when running replicated components for high availability.
```

which we don't really need in minikube. This should reduce overall overhead by ~12%
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 9, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 9, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @priyawadhwa,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test 
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.11.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.11.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="0e15aecdc38b3877059fc19e94926e7969885163"" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: extracting github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: extracting github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
go: extracting github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
go: finding github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: finding github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: finding github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading k8s.io/api v0.17.3
go: extracting github.com/olekukonko/tablewriter v0.0.4
go: downloading k8s.io/apimachinery v0.17.3
go: extracting github.com/libvirt/libvirt-go v3.4.0+incompatible
go: extracting github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: extracting k8s.io/client-go v0.17.3
go: extracting k8s.io/apimachinery v0.17.3
go: extracting github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: extracting github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: extracting github.com/cheggaaa/pb v1.0.27
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: extracting github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: extracting github.com/spf13/viper v1.7.0
go: extracting golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/gogo/protobuf v1.3.1
go: extracting github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/mattn/go-isatty v0.0.12
go: extracting github.com/mattn/go-isatty v0.0.12
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: extracting github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/VividCortex/ewma v1.1.1
go: extracting k8s.io/api v0.17.3
go: extracting github.com/hashicorp/hcl v1.0.0
go: downloading github.com/subosito/gotenv v1.2.0
go: extracting github.com/VividCortex/ewma v1.1.1
go: extracting github.com/otiai10/copy v1.0.2
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/spf13/cobra v1.0.0
go: extracting github.com/spf13/cobra v1.0.0
go: extracting github.com/subosito/gotenv v1.2.0
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading github.com/ulikunitz/xz v0.5.7
go: extracting k8s.io/klog v1.0.0
go: downloading gopkg.in/yaml.v2 v2.3.0
go: extracting github.com/mattn/go-colorable v0.1.6
go: downloading github.com/docker/go-units v0.4.0
go: extracting github.com/gogo/protobuf v1.3.1
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: extracting github.com/ulikunitz/xz v0.5.7
go: extracting github.com/fatih/color v1.9.0
go: downloading github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: extracting github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: extracting github.com/pkg/errors v0.9.1
go: extracting github.com/docker/go-units v0.4.0
go: downloading github.com/json-iterator/go v1.1.8
go: extracting gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/spf13/cast v1.3.1
go: extracting github.com/json-iterator/go v1.1.8
go: extracting github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: downloading gopkg.in/ini.v1 v1.56.0
go: extracting github.com/spf13/cast v1.3.1
go: extracting github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading cloud.google.com/go v0.57.0
go: extracting github.com/docker/go-connections v0.4.0
go: extracting gopkg.in/ini.v1 v1.56.0
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: extracting github.com/mitchellh/go-homedir v1.1.0
go: downloading k8s.io/kubectl v0.17.3
go: extracting github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: extracting cloud.google.com/go v0.57.0
go: extracting github.com/mattn/go-runewidth v0.0.7
go: downloading k8s.io/kubernetes v1.17.3
go: extracting gopkg.in/inf.v0 v0.9.1
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: extracting github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: extracting github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading cloud.google.com/go/storage v1.8.0
go: extracting github.com/docker/distribution v2.7.1+incompatible
go: extracting github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: extracting k8s.io/kubectl v0.17.3
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: extracting cloud.google.com/go/storage v1.8.0
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: extracting github.com/aws/aws-sdk-go v1.31.6
go: extracting github.com/spf13/afero v1.2.2
go: extracting k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: extracting github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: extracting k8s.io/kubernetes v1.17.3
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: extracting github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: extracting github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/magiconair/properties v1.8.1
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/google/gofuzz v1.0.0
go: downloading google.golang.org/grpc v1.29.1
go: extracting github.com/davecgh/go-spew v1.1.1
go: extracting golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: extracting github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/googleapis/gnostic v0.3.0
go: extracting github.com/googleapis/gax-go v2.0.2+incompatible
go: extracting google.golang.org/grpc v1.29.1
go: extracting github.com/pelletier/go-toml v1.8.0
go: extracting github.com/google/gofuzz v1.0.0
go: extracting github.com/magiconair/properties v1.8.1
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: extracting google.golang.org/api v0.25.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: extracting github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading go.opencensus.io v0.22.3
go: extracting github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: extracting github.com/googleapis/gnostic v0.3.0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: extracting golang.org/x/sys v0.0.0-20200523222454-059865788121
go: extracting github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: extracting github.com/googleapis/gax-go/v2 v2.0.5
go: extracting github.com/hashicorp/go-version v1.2.0
go: extracting github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: extracting github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: extracting google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: extracting go.opencensus.io v0.22.3
go: extracting github.com/hashicorp/go-safetemp v1.0.0
go: extracting golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/golang/protobuf v1.4.2
go: extracting github.com/modern-go/reflect2 v1.0.1
go: extracting sigs.k8s.io/yaml v1.1.0
go: extracting github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: extracting github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: extracting github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading k8s.io/kube-proxy v0.17.3
go: extracting golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: extracting github.com/golang/protobuf v1.4.2
go: extracting github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/blang/semver v3.5.0+incompatible
go: extracting golang.org/x/text v0.3.2
go: extracting k8s.io/component-base v0.17.3
go: extracting github.com/fsnotify/fsnotify v1.4.9
go: extracting github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: extracting k8s.io/kube-proxy v0.17.3
go: downloading github.com/google/go-cmp v0.4.1
go: extracting github.com/spf13/jwalterweatherman v1.1.0
go: downloading google.golang.org/protobuf v1.24.0
go: downloading k8s.io/kubelet v0.17.3
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: extracting github.com/opencontainers/go-digest v1.0.0-rc1
go: extracting github.com/blang/semver v3.5.0+incompatible
go: extracting github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: extracting github.com/imdario/mergo v0.3.9
go: extracting google.golang.org/protobuf v1.24.0
go: extracting k8s.io/kubelet v0.17.3
go: extracting github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: extracting github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: extracting github.com/google/go-cmp v0.4.1
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/spf13/pflag v1.0.5
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: extracting github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: extracting github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: extracting k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: extracting github.com/spf13/pflag v1.0.5
go: extracting sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: extracting github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: extracting github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/prometheus/client_golang v1.1.0
go: extracting github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/google/uuid v1.1.1
go: extracting github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: extracting golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: downloading github.com/miekg/dns v1.1.4
go: extracting github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: extracting github.com/jmespath/go-jmespath v0.3.0
go: extracting github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: extracting github.com/google/uuid v1.1.1
go: extracting github.com/sirupsen/logrus v1.6.0
go: extracting github.com/miekg/dns v1.1.4
go: extracting github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: extracting github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: extracting k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: extracting github.com/prometheus/client_golang v1.1.0
go: downloading github.com/prometheus/common v0.6.0
go: downloading github.com/prometheus/procfs v0.0.5
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: extracting github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: extracting github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: extracting github.com/prometheus/procfs v0.0.5
go: extracting github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: extracting github.com/shurcooL/sanitized_anchor_name v1.0.0
go: extracting github.com/prometheus/common v0.6.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: extracting github.com/beorn7/perks v1.0.1
go: extracting github.com/matttproud/golang_protobuf_extensions v1.0.1
go: finding github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: finding github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: finding github.com/pkg/errors v0.9.1
go: finding github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: finding github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: finding github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: finding github.com/docker/go-units v0.4.0
go: finding github.com/spf13/cobra v1.0.0
go: finding github.com/olekukonko/tablewriter v0.0.4
go: finding github.com/blang/semver v3.5.0+incompatible
go: finding k8s.io/client-go v0.17.3
go: finding github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: finding github.com/spf13/viper v1.7.0
go: finding github.com/libvirt/libvirt-go v3.4.0+incompatible
go: finding golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: finding github.com/mattn/go-runewidth v0.0.7
go: finding github.com/imdario/mergo v0.3.9
go: finding k8s.io/api v0.17.3
go: finding github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: finding github.com/spf13/pflag v1.0.5
go: finding k8s.io/apimachinery v0.17.3
go: finding golang.org/x/sys v0.0.0-20200523222454-059865788121
go: finding github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: finding github.com/mattn/go-isatty v0.0.12
go: finding github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: finding github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: finding github.com/gogo/protobuf v1.3.1
go: finding github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: finding github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: finding github.com/google/uuid v1.1.1
go: finding github.com/fsnotify/fsnotify v1.4.9
go: finding github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: finding github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: finding github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: finding github.com/hashicorp/hcl v1.0.0
go: finding github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: finding github.com/magiconair/properties v1.8.1
go: finding github.com/shirou/gopsutil v2.18.12+incompatible
go: finding github.com/mitchellh/mapstructure v1.3.1
go: finding github.com/google/gofuzz v1.0.0
go: finding github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: finding sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: finding k8s.io/klog v1.0.0
go: finding golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: finding github.com/pelletier/go-toml v1.8.0
go: finding cloud.google.com/go/storage v1.8.0
go: finding github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: finding github.com/docker/docker-credential-helpers v0.6.3
go: finding github.com/otiai10/copy v1.0.2
go: finding github.com/cpuguy83/go-md2man/v2 v2.0.0
go: finding github.com/cenkalti/backoff v2.2.1+incompatible
go: finding github.com/golang/protobuf v1.4.2
go: finding gopkg.in/inf.v0 v0.9.1
go: finding github.com/spf13/afero v1.2.2
go: finding golang.org/x/text v0.3.2
go: finding github.com/googleapis/gnostic v0.3.0
go: finding github.com/spf13/cast v1.3.1
go: finding github.com/docker/distribution v2.7.1+incompatible
go: finding cloud.google.com/go v0.57.0
go: finding github.com/russross/blackfriday/v2 v2.0.1
go: finding golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: finding github.com/prometheus/client_golang v1.1.0
go: finding github.com/spf13/jwalterweatherman v1.1.0
go: finding k8s.io/kubernetes v1.17.3
go: finding gopkg.in/yaml.v2 v2.3.0
go: finding github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: finding golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: finding github.com/subosito/gotenv v1.2.0
go: finding github.com/googleapis/gax-go/v2 v2.0.5
go: finding github.com/shurcooL/sanitized_anchor_name v1.0.0
go: finding gopkg.in/ini.v1 v1.56.0
go: finding google.golang.org/protobuf v1.24.0
go: finding github.com/cheggaaa/pb/v3 v3.0.1
go: finding github.com/opencontainers/go-digest v1.0.0-rc1
go: finding google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: finding google.golang.org/api v0.25.0
go: finding google.golang.org/grpc v1.29.1
go: finding k8s.io/component-base v0.17.3
go: finding github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: finding k8s.io/kubectl v0.17.3
go: finding go.opencensus.io v0.22.3
go: finding github.com/json-iterator/go v1.1.8
go: finding github.com/beorn7/perks v1.0.1
go: finding github.com/docker/go-connections v0.4.0
go: finding github.com/VividCortex/ewma v1.1.1
go: finding github.com/modern-go/reflect2 v1.0.1
go: finding github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: finding github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: finding github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: finding github.com/fatih/color v1.9.0
go: finding github.com/prometheus/common v0.6.0
go: finding github.com/opencontainers/image-spec v1.0.1
go: finding github.com/mattn/go-colorable v0.1.6
go: finding github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: finding github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: finding github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: finding github.com/davecgh/go-spew v1.1.1
go: finding golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: finding github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: finding github.com/prometheus/procfs v0.0.5
go: finding k8s.io/cluster-bootstrap v0.17.3
go: finding github.com/sirupsen/logrus v1.6.0
go: finding github.com/matttproud/golang_protobuf_extensions v1.0.1
go: finding sigs.k8s.io/yaml v1.1.0
go: finding k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: finding github.com/mitchellh/go-wordwrap v1.0.0
go: finding github.com/aws/aws-sdk-go v1.31.6
go: finding k8s.io/kube-proxy v0.17.3
go: finding k8s.io/kubelet v0.17.3
go: finding github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: finding github.com/miekg/dns v1.1.4
go: finding github.com/hashicorp/go-cleanhttp v0.5.1
go: finding github.com/hashicorp/go-safetemp v1.0.0
go: finding github.com/hashicorp/go-version v1.2.0
go: finding github.com/hashicorp/golang-lru v0.5.3
go: finding github.com/mitchellh/go-homedir v1.1.0
go: finding github.com/mitchellh/go-testing-interface v1.0.0
go: finding github.com/ulikunitz/xz v0.5.7
go: finding github.com/google/go-cmp v0.4.1
go: finding k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: finding github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: finding github.com/jmespath/go-jmespath v0.3.0
go: finding github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: extracting github.com/pmezard/go-difflib v1.0.0
go: extracting github.com/evanphx/json-patch v4.5.0+incompatible
go: extracting golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: finding github.com/pmezard/go-difflib v1.0.0
go: finding golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: finding github.com/evanphx/json-patch v4.5.0+incompatible
ok  	k8s.io/minikube/cmd/minikube/cmd	4.300s	coverage: 20.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.153s	coverage: 21.7% of statements
ok  	k8s.io/minikube/pkg/addons	0.065s	coverage: 56.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.010s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.011s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.027s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	1.121s	coverage: 55.7% of statements
--- FAIL: TestGenerateKubeadmYAMLDNS (0.00s)
    --- FAIL: TestGenerateKubeadmYAMLDNS/dns_v1.19 (0.00s)
        kubeadm_test.go:162: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.19.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.19.0
            networking:
              dnsDomain: 1.1.1.1
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAMLDNS/dns_v1.18 (0.00s)
        kubeadm_test.go:162: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.18.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.18.0
            networking:
              dnsDomain: 1.1.1.1
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAMLDNS/dns_v1.17 (0.00s)
        kubeadm_test.go:162: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.17.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.17.0
            networking:
              dnsDomain: 1.1.1.1
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
--- FAIL: TestGenerateKubeadmYAML (0.02s)
    --- FAIL: TestGenerateKubeadmYAML/default_v1.19 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.19.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.19.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/containerd_v1.19 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.19.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /run/containerd/containerd.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.19.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/crio_v1.19 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.19.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/crio/crio.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.19.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/options_v1.19 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -40,2 +40,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.19.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
                fail-no-swap: "true"
            controllerManager:
              extraArgs:
                kube-api-burst: "32"
            scheduler:
              extraArgs:
                scheduler-name: "mini-scheduler"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.19.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
            mode: "iptables"
    --- FAIL: TestGenerateKubeadmYAML/crio-options-gates_v1.19 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -43,2 +43,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.19.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/crio/crio.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
                fail-no-swap: "true"
                feature-gates: "a=b"
            controllerManager:
              extraArgs:
                feature-gates: "a=b"
                kube-api-burst: "32"
            scheduler:
              extraArgs:
                feature-gates: "a=b"
                scheduler-name: "mini-scheduler"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.19.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
            mode: "iptables"
    --- FAIL: TestGenerateKubeadmYAML/containerd-api-port_v1.19 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.19.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 12345
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /run/containerd/containerd.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:12345
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.19.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/containerd-pod-network-cidr_v1.19 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.19.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /run/containerd/containerd.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.19.0
            networking:
              dnsDomain: cluster.local
              podSubnet: "192.168.32.0/20"
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: "192.168.32.0/20"
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/image-repository_v1.19 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -34,2 +34,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.19.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            imageRepository: test/repo
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.19.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/default_v1.18 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.18.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.18.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/containerd_v1.18 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.18.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /run/containerd/containerd.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.18.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/crio_v1.18 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.18.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/crio/crio.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.18.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/options_v1.18 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -40,2 +40,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.18.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
                fail-no-swap: "true"
            controllerManager:
              extraArgs:
                kube-api-burst: "32"
            scheduler:
              extraArgs:
                scheduler-name: "mini-scheduler"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.18.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
            mode: "iptables"
    --- FAIL: TestGenerateKubeadmYAML/crio-options-gates_v1.18 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -43,2 +43,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.18.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/crio/crio.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
                fail-no-swap: "true"
                feature-gates: "a=b"
            controllerManager:
              extraArgs:
                feature-gates: "a=b"
                kube-api-burst: "32"
            scheduler:
              extraArgs:
                feature-gates: "a=b"
                scheduler-name: "mini-scheduler"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.18.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
            mode: "iptables"
    --- FAIL: TestGenerateKubeadmYAML/containerd-api-port_v1.18 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.18.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 12345
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /run/containerd/containerd.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:12345
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.18.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/containerd-pod-network-cidr_v1.18 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.18.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /run/containerd/containerd.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.18.0
            networking:
              dnsDomain: cluster.local
              podSubnet: "192.168.32.0/20"
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: "192.168.32.0/20"
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/image-repository_v1.18 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -34,2 +34,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.18.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            imageRepository: test/repo
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.18.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/default_v1.17 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.17.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.17.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/containerd_v1.17 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.17.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /run/containerd/containerd.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.17.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/crio_v1.17 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.17.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/crio/crio.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.17.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/options_v1.17 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -40,2 +40,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.17.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
                fail-no-swap: "true"
            controllerManager:
              extraArgs:
                kube-api-burst: "32"
            scheduler:
              extraArgs:
                scheduler-name: "mini-scheduler"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.17.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
            mode: "iptables"
    --- FAIL: TestGenerateKubeadmYAML/crio-options-gates_v1.17 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -43,2 +43,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.17.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/crio/crio.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
                fail-no-swap: "true"
                feature-gates: "a=b"
            controllerManager:
              extraArgs:
                feature-gates: "a=b"
                kube-api-burst: "32"
            scheduler:
              extraArgs:
                feature-gates: "a=b"
                scheduler-name: "mini-scheduler"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.17.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
            mode: "iptables"
    --- FAIL: TestGenerateKubeadmYAML/containerd-api-port_v1.17 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.17.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 12345
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /run/containerd/containerd.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:12345
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.17.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/containerd-pod-network-cidr_v1.17 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -33,2 +33,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.17.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /run/containerd/containerd.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.17.0
            networking:
              dnsDomain: cluster.local
              podSubnet: "192.168.32.0/20"
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: "192.168.32.0/20"
            metricsBindAddress: 1.1.1.1:10249
    --- FAIL: TestGenerateKubeadmYAML/image-repository_v1.17 (0.00s)
        kubeadm_test.go:243: unexpected diff:
            --- Expected
            +++ Got
            @@ -34,2 +34,8 @@
                 dataDir: /var/lib/minikube/etcd
            +controllerManager:
            +  extraArgs:
            +    "leader-elect": "false"
            +scheduler:
            +  extraArgs:
            +    "leader-elect": "false"
             kubernetesVersion: v1.17.0
            
            ===== [RAW OUTPUT] =====
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: InitConfiguration
            localAPIEndpoint:
              advertiseAddress: 1.1.1.1
              bindPort: 8443
            bootstrapTokens:
              - groups:
                  - system:bootstrappers:kubeadm:default-node-token
                ttl: 24h0m0s
                usages:
                  - signing
                  - authentication
            nodeRegistration:
              criSocket: /var/run/dockershim.sock
              name: "mk"
              kubeletExtraArgs:
                node-ip: 1.1.1.1
              taints: []
            ---
            apiVersion: kubeadm.k8s.io/v1beta2
            kind: ClusterConfiguration
            imageRepository: test/repo
            apiServer:
              certSANs: ["127.0.0.1", "localhost", "1.1.1.1"]
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs
            clusterName: mk
            controlPlaneEndpoint: control-plane.minikube.internal:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /var/lib/minikube/etcd
            controllerManager:
              extraArgs:
                "leader-elect": "false"
            scheduler:
              extraArgs:
                "leader-elect": "false"
            kubernetesVersion: v1.17.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            # disable disk resource management by default
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
            ---
            apiVersion: kubeproxy.config.k8s.io/v1alpha1
            kind: KubeProxyConfiguration
            clusterCIDR: ""
            metricsBindAddress: 1.1.1.1:10249
FAIL
coverage: 63.2% of statements
FAIL	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.082s
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.005s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.011s	coverage: 88.9% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.059s	coverage: 16.9% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.019s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.124s	coverage: 67.3% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.046s	coverage: 40.6% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.016s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.018s	coverage: 37.1% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.020s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.027s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.025s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.009s	coverage: 51.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.068s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.269s	coverage: 38.7% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.011s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.043s	coverage: 67.4% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.253s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.007s	coverage: 91.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.007s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.006s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.081s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.013s	coverage: 96.9% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.040s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.018s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.005s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.634s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.710s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.011s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.013s	coverage: 0.0% of statements
FAIL
Makefile:271: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: f4e34170-aa93-11ea-9064-4d6590cbb359

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #8431 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8431   +/-   ##
=======================================
  Coverage   34.05%   34.05%           
=======================================
  Files         153      153           
  Lines        9840     9840           
=======================================
  Hits         3351     3351           
  Misses       6086     6086           
  Partials      403      403

@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 10, 2020
tstromberg
tstromberg suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems easy enough! Do you mind adding it to the other ktmpl versions for consistency among Kubernetes releases?

@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [64.976877803 64.516317954 63.63938105599999]
Average time for minikube: 64.37752560433333

Times for Minikube (PR 8431): [81.18499008799999 63.627436309000004 64.317619203]
Average time for Minikube (PR 8431): 69.7100152

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8431) |
+--------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian   |  0.054599 |           0.064245 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020433 |           0.037696 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004705 |           0.004138 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.438036 |          40.380145 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.680096 |          27.356391 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.745230 |           1.482440 |
| components...                  |           |                    |
| * Enabled addons:              |  0.353124 |           0.313222 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.077480 |           0.066465 |
| configured to use "minikube"   |           |                    |
|                                |  0.003823 |           0.005275 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.084881562 26.155097273 27.774074633999998]
Average time for minikube: 27.00468448966667

Times for Minikube (PR 8431): [25.500323742 26.082818228 28.064057732000006]
Average time for Minikube (PR 8431): 26.54906656733333

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8431) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian           |  0.074986 |           0.071328 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002565 |           0.002474 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.056317 |           0.057689 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.594226 |           7.513783 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.3         |  0.116540 |           0.114856 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.833253 |          17.930651 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.150863 |           0.787571 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.111314 |           0.002916 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.061022 |           0.063117 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003599 |           0.004681 |
+----------------------------------------+-----------+--------------------+

@priyawadhwa priyawadhwa merged commit b9c8709 into kubernetes:master Jun 10, 2020
@priyawadhwa priyawadhwa deleted the leaderelection branch June 10, 2020 23:05
@priyawadhwa priyawadhwa mentioned this pull request Aug 13, 2020
Closed
@tstromberg tstromberg mentioned this pull request Aug 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@priyawadhwa @k8s-ci-robot @TravisBuddy @codecov-commenter @tstromberg @minikube-pr-bot