WIP: apply CNI to control plane when adding first worker node

[sharifelgamal]

No description provided.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #8171 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8171      +/-   ##
==========================================
- Coverage   34.60%   34.56%   -0.04%     
==========================================
  Files         147      147              
  Lines        9378     9387       +9     
==========================================
  Hits         3245     3245              
- Misses       5736     5745       +9     
  Partials      397      397              

Impacted Files	Coverage Δ
cmd/minikube/cmd/node_add.go	13.51% <0.00%> (-4.35%)	⬇️
cmd/minikube/cmd/start.go	15.10% <0.00%> (ø)

[sharifelgamal]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
docker Driver

[minikube-pr-bot]

kvm2 Driver
Times for minikube: [66.159907884 66.99033260099999 64.68159482499999]
Average time for minikube: 65.94394510333333

Times for Minikube (PR 8171): [68.119855388 64.145594919 64.298124685]
Average time for Minikube (PR 8171): 65.521191664

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8171) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.065475 |           0.067064 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.022620 |           0.024236 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003719 |           0.004159 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.593152 |          40.171947 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 23.019103 |          23.004508 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.481542 |           1.616325 |
| components...                  |           |                    |
| * Enabled addons:              |  0.673822 |           0.536791 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080796 |           0.090218 |
| configured to use "minikube"   |           |                    |
|                                |  0.003714 |           0.005944 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.463350727000005 29.70139936 27.507381688]
Average time for minikube: 28.557377258333332

Times for Minikube (PR 8171): [27.830865885999998 29.439356494000002 28.73832133]
Average time for Minikube (PR 8171): 28.66951457

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8171) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.087346 |           0.083269 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.003453 |           0.003245 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.067325 |           0.066402 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.292063 |           8.387537 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.133483 |           0.135883 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.540420 |          18.872325 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.358054 |           1.035632 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.003023 |           0.003314 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.067553 |           0.075086 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004656 |           0.006822 |
+----------------------------------------+-----------+--------------------+

[k8s-ci-robot]

@sharifelgamal: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tstromberg]

Marking as obsolete.