Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that minikube with kubeadm needs 2 CPUs #8049

Merged
merged 1 commit into from
May 8, 2020

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented May 8, 2020

Eventually this also needs better validation, both for none and for docker driver.

This is supposed to be synced with the information https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#before-you-begin

2 GB or more of RAM per machine (any less will leave little room for your apps)
2 CPUs or more

The memory size is a little misleading (since it uses 2200M, not 2048M) but is not about cpus.
And we accept both 1GB (with a warning, and probably swap) and 2000 without any complaint.

For #6961 #7445 #7782 #7907 #7850 #8045

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #8049 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8049   +/-   ##
=======================================
  Coverage   35.76%   35.76%           
=======================================
  Files         143      143           
  Lines        9191     9191           
=======================================
  Hits         3287     3287           
  Misses       5504     5504           
  Partials      400      400           

Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@afbjorklund
Copy link
Collaborator Author

It's a little confusing terminology, like "do you mean 2 cores ? or 2 sockets ? or 2 vCPU"
But better keep it same as upstream (2 CPUs). We just mean two threads, I think ?

Similarly, I'm not sure if it means 2000 MB or 2048 MB. Or should that be "mebibytes" ?
You're supposed to spell it "2 GiB", but who does that. And the KVM translation is off...

But what we do want to avoid is an error, later on.

Range of CPUs is from 0.01 to 1.00, as there are only 1 CPUs available.

[ERROR NumCPU]: the number of available CPUs 1 is less than the required 2

So let's use the term CPUs, it's what everyone is using.

@afbjorklund
Copy link
Collaborator Author

And fortunately Docker allocates 2 vCPUs for their VM, by default. (see #7980)

So that means we only have problems with the memory, not with the CPUs.

@medyagh medyagh merged commit d995b1d into kubernetes:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants