-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that minikube with kubeadm needs 2 CPUs #8049
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #8049 +/- ##
=======================================
Coverage 35.76% 35.76%
=======================================
Files 143 143
Lines 9191 9191
=======================================
Hits 3287 3287
Misses 5504 5504
Partials 400 400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
It's a little confusing terminology, like "do you mean 2 cores ? or 2 sockets ? or 2 vCPU" Similarly, I'm not sure if it means 2000 MB or 2048 MB. Or should that be "mebibytes" ? But what we do want to avoid is an error, later on.
So let's use the term CPUs, it's what everyone is using. |
And fortunately Docker allocates 2 vCPUs for their VM, by default. (see #7980) So that means we only have problems with the memory, not with the CPUs. |
Eventually this also needs better validation, both for none and for docker driver.
This is supposed to be synced with the information https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#before-you-begin
The memory size is a little misleading (since it uses 2200M, not 2048M) but is not about cpus.
And we accept both 1GB (with a warning, and probably swap) and 2000 without any complaint.
For #6961 #7445 #7782 #7907 #7850 #8045