-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restart: validate configs with new hostname, add logging #8022
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 Driver |
kvm2 Driver Times for Minikube (PR 8022): [65.43820656700001 65.48533936100002 65.50595167399999] Averages Time Per Log
docker Driver Times for Minikube (PR 8022): [26.311212225000006 27.346009181999996 26.412358615] Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with required comment with links for integration test failures.
Fixes an important root cause issue:
kubeconfig
endpoint check still referenced IP addresses after we had migrated to usingDNS
names, causing us to unnecessarily remove files out every stop/start cycle.Fixes issues which made this difficult to debug:
kubeadm:
reset
terminology withreconfigure
kverify:
apiServerHealthz
now returns errorsapiServerHealthz
now logs the response body, and includes it with errorsMay fix #7704 #7921
This will also make #7895 much easier to debug, but may not fix the underlying issue.