Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct binary for unpacking the preload #7961

Merged
merged 1 commit into from
May 4, 2020

Conversation

afbjorklund
Copy link
Collaborator

Previously hardcoded to always use a Docker volume,
even if using a different container driver (podman).

@afbjorklund afbjorklund requested a review from medyagh May 1, 2020 12:32
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #7961 into master will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7961      +/-   ##
==========================================
+ Coverage   35.71%   36.07%   +0.35%     
==========================================
  Files         149      144       -5     
  Lines        9408     9190     -218     
==========================================
- Hits         3360     3315      -45     
+ Misses       5644     5474     -170     
+ Partials      404      401       -3     
Impacted Files Coverage Δ
cmd/minikube/cmd/tunnel.go 5.26% <100.00%> (+0.13%) ⬆️
pkg/minikube/download/progressbar.go

@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 1, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

pkg/drivers/kic/oci/oci.go Outdated Show resolved Hide resolved
Previously hardcoded to *always* use a Docker volume,
even if using a different container driver (podman).
@medyagh medyagh merged commit 1da92a1 into kubernetes:master May 4, 2020
@afbjorklund
Copy link
Collaborator Author

@medyagh This failed when SELinux was enable on the host.
The mounted file was not properly accessible to the container:

tar (child): /preloaded.tar: Cannot open: Permission denied
-?????????? ? ? ? ? ? preloaded.tar

So it also needs some kind of context added, to the mount.
That is, there needs to be a :Z appended, when getenforce...

https://github.com/containers/libpod/blob/master/troubleshooting.md#2-cant-use-volume-mount-get-permission-denied

Still missing Fedora machines in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants