Increase host creation timeout #7565
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
added
the
approved
tstromberg
changed the title
|
kvm2 Driver |
Codecov Report
@@ Coverage Diff @@
## master #7565 +/- ##
=======================================
Coverage 36.49% 36.49%
=======================================
Files 147 147
Lines 9109 9109
=======================================
Hits 3324 3324
Misses 5398 5398
Partials 387 387
|
tstromberg
changed the title
| // Allow two minutes to create host before failing fast | ||
| if err := timedCreateHost(h, api, 2*time.Minute); err != nil { | ||
|
|
||
| if err := timedCreateHost(h, api, 4*time.Minute); err != nil { |
There was a problem hiding this comment.
one of the reasons that this was made lower was to catch
connecting to SSH...
that meant the SSH keys were not copied to the machine, and no matter how long u try it would not be helpful
how about make this timedCreateHost smarter and fail fast on the things that we can do NOTHING about it
(like SSH problems or network or something like that ?) and for other use cases we can even make it wait longer than 4 mins, we can even do 6 ( good for slow CI machines)
There was a problem hiding this comment.
here is the exact error message if you wanna catch that one to fail fast:
I0212 20:18:31.490329 17811 main.go:110] libmachine: Error dialing TCP: dial tcp 192.168.64.44:22: connect: connection refused
I0212 20:18:35.497395 17811 main.go:110] libmachine: Error dialing TCP: dial tcp 192.168.64.44:22: connect: connection refused
I0212 20:18:39.502636 17811 main.go:110] libmachine: Error dialing TCP: dial tcp 192.168.64.44:22: connect: connection refused
I0212 20:18:43.512406 17811 main.go:110] libmachine: Error dialing TCP: dial tcp 192.168.64.44:22: connect: connection refused
(maybe this might need a PR on libmachine (not sure))
There was a problem hiding this comment.
I don't think it's feasible to detect other conditions. Is 3 minutes an acceptable compromise?
To address #7561