Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none: Add support for OpenRC init (Google CloudShell) #7539

Merged
merged 3 commits into from
Apr 9, 2020

Conversation

tstromberg
Copy link
Contributor

Example output:

* minikube v1.9.2 on Debian 9.12
* Using the none driver based on user configuration
* Kubernetes 1.18.0 is now available. If you would like to upgrade, specify: --kubernetes-version=1.18.0
* Starting control plane node minikube in cluster minikube
* Running on localhost (CPUs=2, Memory=1995MB, Disk=46151MB) ...
* OS release is Debian GNU/Linux 9 (stretch)
* Preparing Kubernetes v1.17.3 on Docker 18.09.6 ...
* Enabling addons: default-storageclass, storage-provisioner
E0408 18:18:13.878823   15558 api_server.go:169] unable to get freezer state: cat: /sys/fs/cgroup/freezer/kubepods/besteffort/pod3e551b553b08452c04f72417e89ace00/fa83f4f99688b84ee28b73e5a196b3706cefd40a60458e218012645fbfa0110d/kubepods/b
urstable/pod2f6d69df3b346291b6f5a4633c49f742/58426a7358c8ce168fd25b86393c4ebd13de0f68556b5bfd8d07857640239142/freezer.state: No such file or directory
E0408 18:18:14.019839   15558 api_server.go:169] unable to get freezer state: cat: /sys/fs/cgroup/freezer/kubepods/besteffort/pod3e551b553b08452c04f72417e89ace00/fa83f4f99688b84ee28b73e5a196b3706cefd40a60458e218012645fbfa0110d/kubepods/b
urstable/pod2f6d69df3b346291b6f5a4633c49f742/58426a7358c8ce168fd25b86393c4ebd13de0f68556b5bfd8d07857640239142/freezer.state: No such file or directory
E0408 18:18:14.794914   15558 api_server.go:169] unable to get freezer state: cat: /sys/fs/cgroup/freezer/kubepods/besteffort/pod3e551b553b08452c04f72417e89ace00/fa83f4f99688b84ee28b73e5a196b3706cefd40a60458e218012645fbfa0110d/kubepods/b
urstable/pod2f6d69df3b346291b6f5a4633c49f742/58426a7358c8ce168fd25b86393c4ebd13de0f68556b5bfd8d07857640239142/freezer.state: No such file or directory
* Configuring local host environment ...
*
! The 'none' driver is designed for experts who need to integrate with an existing VM
* Most users should use the newer 'docker' driver instead, which does not require root!
* For more information, see: https://minikube.sigs.k8s.io/docs/reference/drivers/none/
*
! kubectl and minikube configuration will be stored in /root
! To use kubectl or minikube commands as your own user, you may need to relocate them. For example, to overwrite your own settings, run:
*
  - sudo mv /root/.kube /root/.minikube $HOME
  - sudo chown -R $USER $HOME/.kube $HOME/.minikube
*
* This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true
* Done! kubectl is now configured to use "minikube"
* For best results, install kubectl: https://kubernetes.io/docs/tasks/tools/install-kubectl/

The freezer.state issues are unrelated to OpenRC and will need to be addressed in another PR.

This PR obsoletes #7081

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from RA489 April 9, 2020 01:22
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 9, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f5cd1bb0-7a00-11ea-a8f3-49cc0ccf6032

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2e1697d0-7a01-11ea-a8f3-49cc0ccf6032

@minikube-pr-bot
Copy link

Error: running mkcmp
2020/04/09 01:33:31 Executing run 1/3...
2020/04/09 01:33:31 Running: [/home/performance-monitor/minikube/out/minikube start]...
2020/04/09 01:33:31 Running: [/home/performance-monitor/minikube/out/minikube start]...
2020/04/09 01:34:40 Running: [/home/performance-monitor/.minikube/minikube-binaries/7539/minikube start]...
2020/04/09 01:34:40 Running: [/home/performance-monitor/.minikube/minikube-binaries/7539/minikube start]...
2020/04/09 01:34:40 error deleting minikube: fork/exec /home/performance-monitor/.minikube/minikube-binaries/7539/minikube: exec format error
: exit status 1

@codecov-io
Copy link

Codecov Report

Merging #7539 into master will increase coverage by 0.12%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7539      +/-   ##
==========================================
+ Coverage   36.68%   36.80%   +0.12%     
==========================================
  Files         146      145       -1     
  Lines        8980     8957      -23     
==========================================
+ Hits         3294     3297       +3     
+ Misses       5294     5274      -20     
+ Partials      392      386       -6     
Impacted Files Coverage Δ
cmd/minikube/cmd/docker-env.go 49.47% <0.00%> (+1.02%) ⬆️
cmd/minikube/cmd/status.go 21.18% <0.00%> (+0.69%) ⬆️
pkg/minikube/bootstrapper/bootstrapper.go 0.00% <ø> (ø)
pkg/minikube/bootstrapper/bsutil/binaries.go 5.00% <0.00%> (-0.13%) ⬇️
pkg/minikube/cluster/pause.go 0.00% <0.00%> (ø)
pkg/minikube/cruntime/docker.go 28.16% <75.00%> (-0.49%) ⬇️
pkg/minikube/cruntime/containerd.go 43.26% <100.00%> (-0.49%) ⬇️
pkg/minikube/cruntime/crio.go 52.12% <100.00%> (+1.12%) ⬆️
pkg/minikube/cruntime/cruntime.go 67.92% <100.00%> (+10.42%) ⬆️

@minikube-pr-bot
Copy link

Times for minikube: [68.95545300500001 66.63985675299999 68.64597863000002]
Average time for minikube: 68.08042946266666

Times for Minikube (PR 7539): [67.58835602899998 68.86840695199999 68.999118595]
Average time for Minikube (PR 7539): 68.48529385866668

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7539) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.059861 |           0.052926 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.021516 |           0.020366 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003287 |           0.003626 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.839826 |          42.257913 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.625164 |          23.614740 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.449715 |           2.450696 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.077732 |           0.079572 |
| configured to use "minikube"   |           |                    |
|                                |  0.003329 |           0.005455 |
+--------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

Times for minikube: [68.90858204999999 65.40887037399999 63.917719678]
Average time for minikube: 66.07839070066667

Times for Minikube (PR 7539): [68.74195138600001 64.991751635 67.12844435699999]
Average time for Minikube (PR 7539): 66.95404912599999

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7539) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.057731 |           0.053947 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020320 |           0.020478 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003738 |           0.003700 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.073051 |          41.235503 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.763693 |          23.086484 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.071599 |           2.459528 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.085041 |           0.088767 |
| configured to use "minikube"   |           |                    |
|                                |  0.003217 |           0.005642 |
+--------------------------------+-----------+--------------------+

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow great work. looks good. unit test needs fix

@minikube-pr-bot
Copy link

Times for minikube: [68.46764189899999 68.38081254600002 67.86321683300001]
Average time for minikube: 68.23722375933333

Times for Minikube (PR 7539): [64.359548894 65.176734968 64.594930639]
Average time for Minikube (PR 7539): 64.71040483366666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7539) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.060266 |           0.054540 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.021662 |           0.020450 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.004129 |           0.004014 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.592848 |          40.211242 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.938233 |          22.026607 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.527911 |           2.303556 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.088856 |           0.083888 |
| configured to use "minikube"   |           |                    |
|                                |  0.003318 |           0.006108 |
+--------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

Times for minikube: [66.59476358500001 65.826755426 65.22180778900001]
Average time for minikube: 65.88110893333335

Times for Minikube (PR 7539): [65.939131695 64.942818759 65.061839984]
Average time for Minikube (PR 7539): 65.31459681266666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7539) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054471 |           0.054877 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020816 |           0.020283 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003432 |           0.003949 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.922047 |          40.727358 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.210629 |          22.164666 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.574296 |           2.267084 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.091636 |           0.071240 |
| configured to use "minikube"   |           |                    |
|                                |  0.003782 |           0.005139 |
+--------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

Times for minikube: [65.71756280100001 66.289514285 68.375454689]
Average time for minikube: 66.79417725833333

Times for Minikube (PR 7539): [67.216627992 71.394793778 68.467432124]
Average time for Minikube (PR 7539): 69.02628463133333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7539) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055370 |           0.054625 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020568 |           0.020292 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003760 |           0.003709 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.572543 |          43.166674 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.557189 |          23.502361 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.496420 |           2.194393 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.084553 |           0.079533 |
| configured to use "minikube"   |           |                    |
|                                |  0.003773 |           0.004698 |
+--------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

Times for minikube: [67.390345028 64.258837438 65.524141206]
Average time for minikube: 65.724441224

Times for Minikube (PR 7539): [65.622515633 65.008986253 68.56538193799999]
Average time for Minikube (PR 7539): 66.39896127466668

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7539) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.052744 |           0.054798 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019539 |           0.020798 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003189 |           0.003837 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.013450 |          40.571111 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.675290 |          23.544647 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.876056 |           2.117557 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080520 |           0.082089 |
| configured to use "minikube"   |           |                    |
|                                |  0.003653 |           0.004124 |
+--------------------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 6d05265 into kubernetes:master Apr 9, 2020
@minikube-pr-bot
Copy link

Times for minikube: [65.461176751 66.46265125000001 67.56637883600001]
Average time for minikube: 66.49673561233334

Times for Minikube (PR 7539): [69.090498178 65.71119566600001 69.408132669]
Average time for Minikube (PR 7539): 68.069942171

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7539) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055357 |           0.055339 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020507 |           0.020288 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003564 |           0.003615 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.015614 |          43.034095 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.075686 |          22.436731 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.237928 |           2.439759 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.083611 |           0.075436 |
| configured to use "minikube"   |           |                    |
|                                |  0.004468 |           0.004679 |
+--------------------------------+-----------+--------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants