-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
none: Add support for OpenRC init (Google CloudShell) #7539
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Travis tests have failedHey @tstromberg, TravisBuddy Request Identifier: f5cd1bb0-7a00-11ea-a8f3-49cc0ccf6032 |
Travis tests have failedHey @tstromberg, TravisBuddy Request Identifier: 2e1697d0-7a01-11ea-a8f3-49cc0ccf6032 |
Error: running mkcmp |
Codecov Report
@@ Coverage Diff @@
## master #7539 +/- ##
==========================================
+ Coverage 36.68% 36.80% +0.12%
==========================================
Files 146 145 -1
Lines 8980 8957 -23
==========================================
+ Hits 3294 3297 +3
+ Misses 5294 5274 -20
+ Partials 392 386 -6
|
Times for minikube: [68.95545300500001 66.63985675299999 68.64597863000002] Times for Minikube (PR 7539): [67.58835602899998 68.86840695199999 68.999118595] Averages Time Per Log
|
Times for minikube: [68.90858204999999 65.40887037399999 63.917719678] Times for Minikube (PR 7539): [68.74195138600001 64.991751635 67.12844435699999] Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow great work. looks good. unit test needs fix
Times for minikube: [68.46764189899999 68.38081254600002 67.86321683300001] Times for Minikube (PR 7539): [64.359548894 65.176734968 64.594930639] Averages Time Per Log
|
Times for minikube: [66.59476358500001 65.826755426 65.22180778900001] Times for Minikube (PR 7539): [65.939131695 64.942818759 65.061839984] Averages Time Per Log
|
Times for minikube: [65.71756280100001 66.289514285 68.375454689] Times for Minikube (PR 7539): [67.216627992 71.394793778 68.467432124] Averages Time Per Log
|
Times for minikube: [67.390345028 64.258837438 65.524141206] Times for Minikube (PR 7539): [65.622515633 65.008986253 68.56538193799999] Averages Time Per Log
|
Times for minikube: [65.461176751 66.46265125000001 67.56637883600001] Times for Minikube (PR 7539): [69.090498178 65.71119566600001 69.408132669] Averages Time Per Log
|
Example output:
The
freezer.state
issues are unrelated to OpenRC and will need to be addressed in another PR.This PR obsoletes #7081