-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new wait component apps_running #7460
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Error: running mkcmp: exit status 1 |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #7460 +/- ##
=======================================
Coverage 37.07% 37.07%
=======================================
Files 146 146
Lines 8871 8871
=======================================
Hits 3289 3289
Misses 5193 5193
Partials 389 389 |
All Times Minikube (PR 7460): [ 65.191856 64.364387 65.393601] Average minikube: 64.262466 Averages Time Per Log
|
This PR reveals that our NewestCNI is broken. created an issue for it #7466 |
closes #7431
wait=true or wait=all will wait for a new component called "apps_running"
this should reduce test start stop fails, by waiting for more components
the new wait components is called apps_running