--wait, wait for more components

[medyagh]

redoing this PR #7209
adding a new component (default service account) to wait for.
based suggestions in this comment #7209 (comment)

minikube start --wait=false: wait for nothing, same as today
minikube start --wait=responses -- default: no behavioral change from today
minikube start --wait=all -- wait for everything

minikube start --wait=true -- alias for "all" for backwards compatibility

closes #7011

Before this PR:

      --wait=true: Block until the apiserver is servicing API requests

After this PR:

      --wait=[apiserver,system_pods]: comma separated list of kuberentes components to verify and wait for after starting a cluster. defaults to "apiserver,system_pods", available options: "apiserver,system_pods,default_sa" . other acceptable values are 'all' or 'none', 'true' and 'false'

one question this PR does not solve.

do we need to respect the wait flags in a restart ?
the current minikube HEAD does not care about wait=false in a restart.

minikube/pkg/minikube/bootstrapper/kubeadm/kubeadm.go

Line 497 in 5806bb0

// We must ensure that the apiserver is healthy before proceeding

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

/ok-to-test

[codecov-io]

Codecov Report

Merging #7375 into master will decrease coverage by 0.09%.
The diff coverage is 20.68%.

@@            Coverage Diff             @@
##           master    #7375      +/-   ##
==========================================
- Coverage   37.16%   37.07%   -0.10%     
==========================================
  Files         146      146              
  Lines        8838     8871      +33     
==========================================
+ Hits         3285     3289       +4     
- Misses       5165     5193      +28     
- Partials      388      389       +1     

Impacted Files	Coverage Δ
cmd/minikube/cmd/start.go	33.67% <20.68%> (-0.67%)	⬇️
pkg/addons/addons.go	43.60% <0.00%> (-1.58%)	⬇️
pkg/minikube/driver/driver.go	62.37% <0.00%> (-0.37%)	⬇️

[minikube-pr-bot]

All Times Minikube (PR 7375): [ 62.233380 62.847805 63.416466]
All Times minikube: [ 63.476439 61.276434 62.893814]

Average minikube: 62.548896
Average Minikube (PR 7375): 62.832550

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7375) |
+----------------------+-----------+--------------------+
| minikube v           |  0.219289 |           0.205154 |
| Creating kvm2        | 39.806416 |          40.260735 |
| Preparing Kubernetes | 20.699085 |          20.757556 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

[tstromberg]

Thank you. I really am looking forward to this PR merging.

[priyawadhwa]

Nice! Mostly just nits

[TravisBuddy]

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 77e11f90-754f-11ea-a262-9b801104bb86

[minikube-pr-bot]

All Times minikube: [ 60.830296 63.130888 64.764703]
All Times Minikube (PR 7375): [ 63.257593 64.842987 63.754107]

Average minikube: 62.908629
Average Minikube (PR 7375): 63.951562

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7375) |
+----------------------+-----------+--------------------+
| minikube v           |  0.224415 |           0.216883 |
| Creating kvm2        | 40.986785 |          40.721300 |
| Preparing Kubernetes | 19.652886 |          20.755679 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

[TravisBuddy]

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5f9af3e0-7552-11ea-a6fd-7b7c169fd25a

[minikube-pr-bot]

All Times minikube: [ 64.694873 61.668277 64.207778]
All Times Minikube (PR 7375): [ 63.725912 65.039639 62.171837]

Average minikube: 63.523643
Average Minikube (PR 7375): 63.645796

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7375) |
+----------------------+-----------+--------------------+
| minikube v           |  0.220018 |           0.219516 |
| Creating kvm2        | 40.453290 |          40.608629 |
| Preparing Kubernetes | 21.036879 |          21.006374 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

[TravisBuddy]

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a4a36080-7552-11ea-a6fd-7b7c169fd25a

[minikube-pr-bot]

All Times Minikube (PR 7375): [ 69.902014 70.012129 66.463619]
All Times minikube: [ 73.725072 65.425998 66.985389]

Average minikube: 68.712153
Average Minikube (PR 7375): 68.792587

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7375) |
+----------------------+-----------+--------------------+
| minikube v           |  0.250965 |           0.250450 |
| Creating kvm2        | 41.445377 |          40.988754 |
| Preparing Kubernetes | 24.052262 |          25.424862 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

[minikube-pr-bot]

All Times minikube: [ 73.455079 65.806522 65.998293]
All Times Minikube (PR 7375): [ 66.088075 69.194314 63.785776]

Average minikube: 68.419964
Average Minikube (PR 7375): 66.356055

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7375) |
+----------------------+-----------+--------------------+
| minikube v           |  0.264068 |           0.236505 |
| Creating kvm2        | 42.979925 |          40.978347 |
| Preparing Kubernetes | 23.094413 |          22.813583 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+