Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

none: Use LookPath to verify conntrack install #7305

Merged
merged 1 commit into from
Mar 29, 2020
Merged

none: Use LookPath to verify conntrack install #7305

merged 1 commit into from
Mar 29, 2020

Conversation

tstromberg
Copy link
Contributor

Likely fixes #7301

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from RA489 March 28, 2020 20:20
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2020
@tstromberg tstromberg changed the title Use LookPath to verify conntrack install none: Use LookPath to verify conntrack install Mar 28, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@codecov-io
Copy link

Codecov Report

Merging #7305 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7305   +/-   ##
=======================================
  Coverage   37.47%   37.47%           
=======================================
  Files         146      146           
  Lines        8870     8869    -1     
=======================================
  Hits         3324     3324           
+ Misses       5141     5140    -1     
  Partials      405      405
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 36.21% <0.00%> (+0.05%) ⬆️

@tstromberg tstromberg mentioned this pull request Mar 28, 2020
Closed
@medyagh medyagh merged commit 233f106 into kubernetes:master Mar 29, 2020
@fmotrifork fmotrifork mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@medyagh medyagh medyagh approved these changes

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

none: "The none driver requires conntrack to be installed" - but it's installed!
6 participants
@tstromberg @k8s-ci-robot @minikube-pr-bot @codecov-io @medyagh @sharifelgamal