-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'stable' and 'latest' as valid kubernetes-version values #7212
Add 'stable' and 'latest' as valid kubernetes-version values #7212
Conversation
Hi @linkvt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: linkvt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your latter idea for the help output. It can be provided in a follow-up PR too.
Error: running mkcmp: exit status 1 |
@tstromberg I added the CLI help changes here and flattened the ifs for parsing the version a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. This is is a useful feature
Fixes #6126
Hi,
mini PR, this was done with quite a lot of other changes in #6142 already but the user deleted his account.
I added the tags to the CLI help output, used a case insensitive comparison and really basic tests which are longer then the actual code but I think they still make sense e.g. to catch errors during refactorings or such.
CLI Output:
Edit: I could adjust the CLI help output to contain the mapping from latest/stable to the appropriate version, it could look like:
BR, Vincent