Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'stable' and 'latest' as valid kubernetes-version values #7212

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Add 'stable' and 'latest' as valid kubernetes-version values #7212

merged 1 commit into from
Mar 25, 2020

Conversation

linkvt
Copy link
Contributor

@linkvt linkvt commented Mar 24, 2020

Fixes #6126

Hi,

mini PR, this was done with quite a lot of other changes in #6142 already but the user deleted his account.

I added the tags to the CLI help output, used a case insensitive comparison and really basic tests which are longer then the actual code but I think they still make sense e.g. to catch errors during refactorings or such.

CLI Output:

 $ out/minikube start --help | grep kubernetes-version
      --kubernetes-version='': The kubernetes version that the minikube VM will use (ex: v1.2.3 or latest/stable for supported versions)

Edit: I could adjust the CLI help output to contain the mapping from latest/stable to the appropriate version, it could look like:

 $ out/minikube start --help | grep kubernetes-version
      --kubernetes-version='': The kubernetes version that the minikube VM will use (ex: v1.2.3, 'stable' for v1.18.0-rc.1, 'latest' for v1.18.0-rc.1)

BR, Vincent

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @linkvt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: linkvt
To complete the pull request process, please assign priyawadhwa
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2020
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your latter idea for the help output. It can be provided in a follow-up PR too.

@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2020
@linkvt
Copy link
Contributor Author

linkvt commented Mar 24, 2020

@tstromberg I added the CLI help changes here and flattened the ifs for parsing the version a bit.

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. This is is a useful feature

@medyagh medyagh merged commit 5ea20f5 into kubernetes:master Mar 25, 2020
@linkvt linkvt deleted the kubernetes-parameters-latest-stable branch March 25, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for --kubernetes-version=(latest|stable) aliases
6 participants