Added hyperv virtual switch configuration flag for hyperv driver #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm but you probably need gendocs? |
aaron-prindle
force-pushed
the
hyperv-switch-flag
branch
from
c1c4cfa
to
89ca18e
Compare
Current coverage is 31.40% (diff: 9.09%)@@ master #719 diff @@
==========================================
Files 42 42
Lines 1956 1958 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 614 615 +1
- Misses 1213 1214 +1
Partials 129 129
|
|
@minikube-bot retest this please |
|
@minikube-bot test this please |
|
LGTM, just fix the merge conflict. |
dlorenc
approved these changes
Oct 20, 2016
aaron-prindle
force-pushed
the
hyperv-switch-flag
branch
from
89ca18e
to
f2f53e9
Compare
dlorenc
approved these changes
Oct 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#561