Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Kubernetes v1.18.0-rc.1 by default #7076

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Use Kubernetes v1.18.0-rc.1 by default #7076

merged 3 commits into from
Mar 18, 2020

Conversation

tstromberg
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2020
@tstromberg tstromberg added this to the v1.9.0 March 24th milestone Mar 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #7076 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7076   +/-   ##
=======================================
  Coverage   36.94%   36.94%           
=======================================
  Files         146      146           
  Lines        9094     9094           
=======================================
  Hits         3360     3360           
  Misses       5322     5322           
  Partials      412      412

@codecov-io
Copy link

Codecov Report

Merging #7076 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7076   +/-   ##
=======================================
  Coverage   36.94%   36.94%           
=======================================
  Files         146      146           
  Lines        9094     9094           
=======================================
  Hits         3360     3360           
  Misses       5322     5322           
  Partials      412      412

@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 17, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 65.156364 68.691894 66.787016]
All Times Minikube (PR 7076): [ 77.109016 67.720433 69.426547]

Average minikube: 66.878425
Average Minikube (PR 7076): 71.418665

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7076) |
+----------------------+-----------+--------------------+
| minikube v           |  0.234460 |           0.240072 |
| Creating kvm2        | 42.530084 |          43.155998 |
| Preparing Kubernetes |  0.862769 |           0.854487 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.372139 |          22.235968 |
| Waiting for cluster  |  0.422065 |           0.749178 |
+----------------------+-----------+--------------------+

@tstromberg
Copy link
Contributor Author

The docker TestVersionUpgrade test results look concerning. Re-running locally.

@tstromberg
Copy link
Contributor Author

/ok-to-test

@tstromberg tstromberg merged commit de5ee57 into kubernetes:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9.0 March 24th
Development

Successfully merging this pull request may close these issues.
4 participants
@tstromberg @k8s-ci-robot @codecov-io @minikube-pr-bot