Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NewestKubernetesVersion to 1.18.0-beta.2 #6988

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Mar 10, 2020

To pass tests, this required updating the Kubernetes image logic.

The update to the Pause image version was particularly annoying, as it required plumbing the Kubernetes version into a few new locations.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2020
@tstromberg tstromberg changed the title Update Newest to 1.18.0-beta.2 Update NewestKubernetesVersion to 1.18.0-beta.2 Mar 10, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh
Copy link
Member

medyagh commented Mar 10, 2020

lets make sure we push a preload tar for this version !

@codecov-io
Copy link

Codecov Report

Merging #6988 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6988   +/-   ##
=======================================
  Coverage   37.18%   37.18%           
=======================================
  Files         144      144           
  Lines        9055     9055           
=======================================
  Hits         3367     3367           
  Misses       5263     5263           
  Partials      425      425           

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2020
@minikube-pr-bot
Copy link

All Times Minikube (PR 6988): [ 67.819619 69.579902 62.717395]
All Times minikube: [ 65.621484 63.435351 65.705548]

Average minikube: 64.920794
Average Minikube (PR 6988): 66.705639

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6988) |
+----------------------+-----------+--------------------+
| minikube v           |  0.223829 |           0.217543 |
| Creating kvm2        | 40.970256 |          41.222363 |
| Preparing Kubernetes |  0.791678 |           0.791161 |
| Pulling images       |           |                    |
| Launching Kubernetes | 19.864450 |          21.223076 |
| Waiting for cluster  |  0.066933 |           0.062285 |
+----------------------+-----------+--------------------+

@priyawadhwa
Copy link

until I set up the automated tarball creation, you can run make upload-preloaded-images-tar on the branch to generate the preloaded tar for this version!

@tstromberg
Copy link
Contributor Author

tstromberg commented Mar 11, 2020

until I set up the automated tarball creation, you can run make upload-preloaded-images-tar on the branch to generate the preloaded tar for this version!

Thanks. There is now preload available for v1.18.0-beta.2: 36s startup time on macOS!

@tstromberg tstromberg merged commit a29c573 into kubernetes:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants