-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use preloaded tarball for VMs as well #6898
Conversation
Since preloaded tarballs are container runtime specific, I added a Preload() func to the cruntime interface. To use it with VMs, the tarball is first copied into the VM and then extracted. The leftover tarball is deleted, and the container runtime (currently only docker is supported) is restarted.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @priyawadhwa, TravisBuddy Request Identifier: 614b3760-5f16-11ea-9418-d96fb954c76d |
/ok-to-test |
Error: running mkcmp: exit status 1 |
All Times minikube: [ 92.092458 94.467348 93.096812] Average minikube: 93.218873 Averages Time Per Log
|
All Times minikube: [ 94.242589 89.956610 92.616504] Average minikube: 92.271901 Averages Time Per Log
|
…preloaded-copy-vm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved assuming integration tests look reasonable.
All Times minikube: [ 95.942146 92.820578 95.622671] Average minikube: 94.795132 Averages Time Per Log
|
Codecov Report
@@ Coverage Diff @@
## master #6898 +/- ##
=========================================
- Coverage 37.11% 37.02% -0.1%
=========================================
Files 144 144
Lines 8955 9010 +55
=========================================
+ Hits 3324 3336 +12
- Misses 5212 5251 +39
- Partials 419 423 +4
|
All Times minikube: [ 92.242851 95.248294 94.366230] Average minikube: 93.952459 Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please feel free to merge if tested manually on VM
Since preloaded tarballs are container runtime specific, I added a Preload() func
to the cruntime interface. To use it with VMs, the tarball is first
copied into the VM and then extracted. The leftover tarball is deleted,
and the container runtime (currently only docker is supported) is
restarted.