Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile list: exit zero even if one profile is not ready #6882

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

nkprince007
Copy link
Contributor

fixes #6851

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @nkprince007. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nkprince007
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josedonizetti
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@minikube-pr-bot
Copy link

All Times minikube: [ 92.571159 94.861225 89.708946]
All Times Minikube (PR 6882): [ 91.163886 91.949091 91.887011]

Average minikube: 92.380443
Average Minikube (PR 6882): 91.666663

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6882) |
+----------------------+-----------+--------------------+
| minikube v           |  0.207311 |           0.205298 |
| Creating kvm2        | 20.095633 |          20.568564 |
| Preparing Kubernetes | 49.067267 |          49.366418 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.456803 |          20.280150 |
| Waiting for cluster  |  0.058696 |           0.054037 |
+----------------------+-----------+--------------------+

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #6882 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6882   +/-   ##
=======================================
  Coverage   38.24%   38.24%           
=======================================
  Files         142      142           
  Lines        8753     8753           
=======================================
  Hits         3348     3348           
  Misses       4984     4984           
  Partials      421      421
Impacted Files Coverage Δ
cmd/minikube/cmd/config/profile_list.go 3.94% <0%> (ø) ⬆️

@minikube-pr-bot
Copy link

All Times minikube: [ 91.894145 92.051163 92.768424]
All Times Minikube (PR 6882): [ 94.902689 94.571242 91.582937]

Average minikube: 92.237911
Average Minikube (PR 6882): 93.685623

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6882) |
+----------------------+-----------+--------------------+
| minikube v           |  0.214848 |           0.210082 |
| Creating kvm2        | 20.302173 |          20.651022 |
| Preparing Kubernetes | 49.107060 |          50.108706 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.382058 |          21.409619 |
| Waiting for cluster  |  0.058621 |           0.063018 |
+----------------------+-----------+--------------------+

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution !

@medyagh medyagh merged commit d1b0d50 into kubernetes:master Mar 4, 2020
@medyagh medyagh changed the title profile_list: Do not throw error for unready clusters profile list: exit zero even if one profile is not ready Mar 4, 2020
@nkprince007 nkprince007 deleted the profile_list branch March 5, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile list should not return error if one cluster is not ready
7 participants