Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change service wait and interval defaults #6845

Conversation

josedonizetti
Copy link
Member

The wait, and interval flags were added to the service command on the PR: #1651

I understand having those flags for one trying to automate something with minikube. But the default values for basic user are too high, it takes 35s to return a service doesn't exist.

time minikube service non-existing

💣  Error opening service: Service non-existing was not found in "default" namespace. You may select another namespace by using 'minikube service non-existing -n <namespace>: Temporary Error: Error getting service non-existing: services "non-existing" not found

😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

real	0m35,478s
user	0m0,125s
sys	0m0,057s

This PR soft the defaults.

time minikube service non-existing

💣  Error opening service: Service non-existing was not found in "default" namespace. You may select another namespace by using 'minikube service non-existing -n <namespace>: Temporary Error: Error getting service non-existing: services "non-existing" not found

😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

real	0m3,376s
user	0m0,048s
sys	0m0,068s

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josedonizetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #6845 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6845   +/-   ##
======================================
  Coverage    38.3%   38.3%           
======================================
  Files         142     142           
  Lines        8740    8740           
======================================
  Hits         3348    3348           
  Misses       4971    4971           
  Partials      421     421
Impacted Files Coverage Δ
pkg/minikube/service/service.go 77.83% <ø> (ø) ⬆️

@medyagh
Copy link
Member

medyagh commented Mar 1, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 1, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh medyagh merged commit 92fe4dd into kubernetes:master Mar 1, 2020
@josedonizetti josedonizetti deleted the change-service-wait-interval-defaults branch March 1, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants